Merge pull request #404 from Goldii-locks/fix/remove-dead-webhook-path-add-eslint

Remove dead duplicate webhook path, add ESLint, unhide 3 test files from tsc

Author: godamongstmen897

.github/workflows/ci.yml

@@ -22,6 +22,9 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
+      - name: Lint
+        run: npm run lint
+
       - name: Type check
         run: npx tsc --noEmit
 

__tests__/database-writer-pool.test.ts

@@ -377,7 +377,7 @@ describe("DatabaseWriterPool – Concurrent Write Operations", () => {
     });
 
     it("flushWriteQueue waits for all pending operations", async () => {
-      let executionOrder: string[] = [];
+      const executionOrder: string[] = [];
 
       const operations = [1, 2, 3].map((num) => ({
         name: `operation-${num}`,

__tests__/milestone-webhook-events.test.ts

@@ -299,11 +299,7 @@ describe("RpcPollerClient – database transaction isolation", () => {
             return result;
           };
           const tx = testDb.transaction(wrapped);
-          try {
-            return tx();
-          } catch (e) {
-            throw e;
-          }
+          return tx();
         };
         Object.assign(wrappedTx, {
           default: () => wrappedTx(),
@@ -337,11 +333,7 @@ describe("RpcPollerClient – database transaction isolation", () => {
             return result;
           };
           const tx = testDb.transaction(wrapped);
-          try {
-            return tx();
-          } catch (e) {
-            throw e;
-          }
+          return tx();
         };
         Object.assign(wrappedTx, {
           default: () => wrappedTx(),
@@ -381,11 +373,7 @@ describe("RpcPollerClient – database transaction isolation", () => {
             return result;
           };
           const tx = testDb.transaction(wrapped);
-          try {
-            return tx();
-          } catch (e) {
-            throw e;
-          }
+          return tx();
         };
         Object.assign(wrappedTx, {
           default: () => wrappedTx(),

__tests__/rpc-poller-client.test.ts

@@ -0,0 +1,65 @@
+import js from "@eslint/js";
+import tseslint from "typescript-eslint";
+
+export default tseslint.config(
+  {
+    ignores: [
+      "dist/**",
+      "node_modules/**",
+      "coverage/**",
+      "eslint.config.mjs",
+      "jest.config.js",
+      "verify-ci.js",
+    ],
+  },
+  js.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    languageOptions: {
+      parserOptions: {
+        projectService: true,
+        tsconfigRootDir: import.meta.dirname,
+      },
+    },
+    rules: {
+      // ── Errors: these catch defects tsc does not ───────────────────────────
+      //
+      // `in` walks the prototype chain. That is precisely how the milestone
+      // webhook guard let "toString" through and shipped a payload whose
+      // newStatus was a function -- code that type-checked perfectly.
+      "no-prototype-builtins": "error",
+      "guard-for-in": "error",
+
+      // A dropped `await` in the indexer swallows failures silently.
+      "@typescript-eslint/no-floating-promises": "error",
+      "@typescript-eslint/await-thenable": "error",
+
+      "no-useless-catch": "error",
+      "prefer-const": "error",
+      eqeqeq: ["error", "smart"],
+
+      // ── Warnings: pre-existing debt, not worth blocking merges over ────────
+      //
+      // Turning these into errors today would mean a typing pass over the
+      // Stellar SDK call sites in src/routes/jobs.ts. Left visible so the
+      // count can come down, rather than hidden so it cannot.
+      "@typescript-eslint/no-unused-vars": [
+        "warn",
+        { argsIgnorePattern: "^_", varsIgnorePattern: "^_" },
+      ],
+      "@typescript-eslint/no-unsafe-call": "warn",
+      "@typescript-eslint/no-explicit-any": "warn",
+
+      // Handled by the TypeScript program; the base rule misfires on globals.
+      "no-undef": "off",
+    },
+  },
+  {
+    files: ["**/*.test.ts", "__tests__/**/*.ts", "jest.setup.ts"],
+    rules: {
+      // Tests deliberately poke at loosely-typed mocks.
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+    },
+  },
+);