Merge pull request #1353 from GolosChain/1348-transit-to-cyberway

Transit to cyberway. #1348

Author: afalaleev

libraries/api/include/golos/api/witness_api_object.hpp

@@ -32,6 +32,7 @@ namespace golos { namespace api {
         version running_version;
         hardfork_version hardfork_version_vote;
         time_point_sec hardfork_time_vote;
+        time_point_sec transit_to_cyberway_vote = STEEMIT_GENESIS_TIME;
     };
 
 } } // golos::api
@@ -42,4 +43,4 @@ FC_REFLECT(
     (id)(owner)(created)(url)(votes)(virtual_last_update)(virtual_position)(virtual_scheduled_time)
     (total_missed)(last_aslot)(last_confirmed_block_num)(pow_worker)(signing_key)(props)
     (sbd_exchange_rate)(last_sbd_exchange_update)(last_work)(running_version)(hardfork_version_vote)
-    (hardfork_time_vote))
+    (hardfork_time_vote)(transit_to_cyberway_vote))

libraries/api/witness_api_object.cpp

@@ -10,6 +10,6 @@ namespace golos { namespace api {
           virtual_last_update(w.virtual_last_update), virtual_position(w.virtual_position),
           virtual_scheduled_time(w.virtual_scheduled_time), last_work(w.last_work),
           running_version(w.running_version), hardfork_version_vote(w.hardfork_version_vote),
-          hardfork_time_vote(w.hardfork_time_vote) {
+          hardfork_time_vote(w.hardfork_time_vote), transit_to_cyberway_vote(w.transit_to_cyberway_vote) {
     }
 } } // golos::api

libraries/chain/chain_properties_evaluators.cpp

@@ -79,4 +79,24 @@ namespace golos { namespace chain {
         }
     }
 
+    void transit_to_cyberway_evaluator::do_apply(const transit_to_cyberway_operation& o) {
+        ASSERT_REQ_HF(STEEMIT_HARDFORK_0_21__1348, "transit_to_cyberway");
+
+        _db.get_account(o.owner); // verify owner exists
+        auto& witness = _db.get_witness(o.owner);
+
+        GOLOS_CHECK_OP_PARAM(o, vote_to_transit, {
+            GOLOS_CHECK_VALUE(o.vote_to_transit != (witness.transit_to_cyberway_vote != STEEMIT_GENESIS_TIME),
+                "You should change your vote.");
+        });
+
+        _db.modify(witness, [&](witness_object& w) {
+            if (o.vote_to_transit) {
+                w.transit_to_cyberway_vote = _db.head_block_time();
+            } else {
+                w.transit_to_cyberway_vote = STEEMIT_GENESIS_TIME;
+            }
+        });
+    }
+
 } } // golos::chain

libraries/chain/database.cpp

@@ -1073,6 +1073,8 @@ namespace golos { namespace chain {
                 GOLOS_ASSERT(fc::raw::pack_size(trx) <= (get_dynamic_global_properties().maximum_block_size - 256),
                         golos::protocol::tx_too_long, "Transaction data is too long. Maximum transaction size ${max} bytes",
                         ("max",get_dynamic_global_properties().maximum_block_size - 256));
+                GOLOS_ASSERT(!is_transit_enabled(), golos::transit_enabled_exception,
+                        "Migrating to CyberWay disabled transaction accepting to prevent user actions lost.");
                 with_weak_write_lock([&]() {
                     detail::with_producing(*this, [&]() {
                         _push_transaction(trx, skip);
@@ -1162,7 +1164,9 @@ namespace golos { namespace chain {
 
                 uint64_t postponed_tx_count = 0;
                 // pop pending state (reset to head block state)
-                for (const signed_transaction &tx : _pending_tx) {
+                if (is_transit_enabled()) {
+                    wlog("Migrating to CyberWay disables generating blocks with transactions.");
+                } else for (const signed_transaction &tx : _pending_tx) {
                     // Only include transactions that have not expired yet for currently generating block,
                     // this should clear problem transactions and allow block production to continue
 
@@ -1475,6 +1479,58 @@ namespace golos { namespace chain {
             }
         }
 
+        bool database::is_transit_enabled() const {
+            return
+                has_hardfork(STEEMIT_HARDFORK_0_21__1348) &&
+                get_dynamic_global_properties().transit_block_num != std::numeric_limits<uint32_t>::max();
+        }
+
+        void database::process_transit_to_cyberway(const signed_block& b, uint32_t skip) {
+            if (!has_hardfork(STEEMIT_HARDFORK_0_21__1348)) {
+                return;
+            }
+
+            const auto& gpo = get_dynamic_global_properties();
+
+            if (!is_transit_enabled()) {
+                vector<account_name_type> transit_witnesses;
+                transit_witnesses.reserve(STEEMIT_MAX_WITNESSES);
+
+                uint32_t i;
+                const auto& wso = get_witness_schedule_object();
+                for (i = 0; i < wso.num_scheduled_witnesses; ++i) {
+                    auto& witness = get_witness(wso.current_shuffled_witnesses[i]);
+                    if (witness.schedule != witness_object::top19) {
+                        //skip
+                    } else if (witness.transit_to_cyberway_vote != STEEMIT_GENESIS_TIME) {
+                        transit_witnesses.push_back(witness.owner);
+                    }
+                }
+
+                if (transit_witnesses.size() >= STEEMIT_TRANSIT_REQUIRED_WITNESSES) {
+                    modify(gpo, [&](auto& o) {
+                        i = 0;
+                        o.transit_block_num = b.block_num();
+                        for (auto owner: transit_witnesses) {
+                            o.transit_witnesses[i++] = owner;
+                        }
+                    });
+                } else {
+                    return;
+                }
+            }
+
+            if (is_transit_enabled()) {
+                if (skip & skip_block_log) {
+                    set_revision(gpo.head_block_number);
+                }
+
+                if (gpo.transit_block_num == gpo.last_irreversible_block_num) {
+                    STEEMIT_TRY_NOTIFY(transit_to_cyberway, b.block_num(), skip);
+                }
+            }
+        }
+
         void database::update_witness_schedule4() {
             vector<account_name_type> active_witnesses;
             active_witnesses.reserve(STEEMIT_MAX_WITNESSES);
@@ -3057,6 +3113,7 @@ namespace golos { namespace chain {
             _my->_evaluator_registry.register_evaluator<delegate_vesting_shares_evaluator>();
             _my->_evaluator_registry.register_evaluator<delegate_vesting_shares_with_interest_evaluator>();
             _my->_evaluator_registry.register_evaluator<reject_vesting_shares_delegation_evaluator>();
+            _my->_evaluator_registry.register_evaluator<transit_to_cyberway_evaluator>();
             _my->_evaluator_registry.register_evaluator<proposal_create_evaluator>();
             _my->_evaluator_registry.register_evaluator<proposal_update_evaluator>();
             _my->_evaluator_registry.register_evaluator<proposal_delete_evaluator>();
@@ -3589,6 +3646,11 @@ namespace golos { namespace chain {
                     );
                 }
 
+                if (is_transit_enabled()) {
+                    FC_ASSERT(next_block.transactions.empty(),
+                        "Migrating to CyberWay disabled accepting blocks with transactions.");
+                }
+
                 for (const auto &trx : next_block.transactions) {
                     /* We do not need to push the undo state for each transaction
                      * because they either all apply and are valid or the
@@ -3610,33 +3672,43 @@ namespace golos { namespace chain {
                 update_last_irreversible_block(skip);
 
                 create_block_summary(next_block);
-                clear_expired_proposals();
-                clear_expired_transactions();
-                clear_expired_orders();
-                clear_expired_delegations();
+
+                if (is_transit_enabled()) {
+                    wlog("Migrating to Cyberway disables the processes to prevent lost of account balances");
+                } else {
+                    clear_expired_proposals();
+                    clear_expired_transactions();
+                    clear_expired_orders();
+                    clear_expired_delegations();
+                }
+
                 update_witness_schedule();
 
-                update_median_feed();
-                update_virtual_supply();
+                if (!is_transit_enabled()) {
+                    update_median_feed();
+                    update_virtual_supply();
 
-                clear_null_account_balance();
-                process_funds();
-                process_conversions();
-                process_comment_cashout();
-                process_vesting_withdrawals();
-                process_savings_withdraws();
-                pay_liquidity_reward();
-                update_virtual_supply();
+                    clear_null_account_balance();
+                    process_funds();
+                    process_conversions();
+                    process_comment_cashout();
+                    process_vesting_withdrawals();
+                    process_savings_withdraws();
+                    pay_liquidity_reward();
+                    update_virtual_supply();
 
-                account_recovery_processing();
-                expire_escrow_ratification();
-                process_decline_voting_rights();
+                    account_recovery_processing();
+                    expire_escrow_ratification();
+                    process_decline_voting_rights();
+                }
 
                 process_hardforks();
 
                 // notify observers that the block has been applied
                 notify_applied_block(next_block);
 
+                process_transit_to_cyberway(next_block, skip);
+
                 notify_changed_objects();
 
             } FC_CAPTURE_LOG_AND_RETHROW((next_block.block_num()))
@@ -3903,9 +3975,7 @@ namespace golos { namespace chain {
                             modify(witness_missed, [&](witness_object &w) {
                                 w.total_missed++;
                                 if (has_hardfork(STEEMIT_HARDFORK_0_14__278)) {
-                                    if (head_block_num() -
-                                        w.last_confirmed_block_num >
-                                        STEEMIT_BLOCKS_PER_DAY) {
+                                    if (head_block_num() - w.last_confirmed_block_num > STEEMIT_BLOCKS_PER_DAY) {
                                         w.signing_key = public_key_type();
                                         push_virtual_operation(shutdown_witness_operation(w.owner));
                                     }
@@ -4076,10 +4146,18 @@ namespace golos { namespace chain {
                                        b->last_confirmed_block_num;
                             });
 
-                    uint32_t new_last_irreversible_block_num = wit_objs[offset]->last_confirmed_block_num;
+                    uint32_t new_last_irreversible_block_num = std::min(
+                        uint32_t(wit_objs[offset]->last_confirmed_block_num),
+                        _fixed_irreversible_block_num);
+
+                    if (new_last_irreversible_block_num > dpo.last_irreversible_block_num) {
+                        if (is_transit_enabled() &&
+                            dpo.transit_block_num > dpo.last_irreversible_block_num &&
+                            dpo.transit_block_num <= new_last_irreversible_block_num
+                        ) {
+                            new_last_irreversible_block_num = dpo.transit_block_num;
+                        }
 
-                    if (new_last_irreversible_block_num >
-                        dpo.last_irreversible_block_num) {
                         modify(dpo, [&](dynamic_global_property_object &_dpo) {
                             _dpo.last_irreversible_block_num = new_last_irreversible_block_num;
                         });

libraries/chain/hardfork.d/0_21.hf

@@ -1,6 +1,9 @@
 #ifndef STEEMIT_HARDFORK_0_21
 #define STEEMIT_HARDFORK_0_21 21
 
+#define STEEMIT_HARDFORK_0_21__1348 (STEEMIT_HARDFORK_0_21) // Transit to CyberWay
+
+
 #ifdef STEEMIT_BUILD_TESTNET
 #define STEEMIT_HARDFORK_0_21_TIME  1563613200 // 20 jul 2019 12:00:00 MSK
 #else

libraries/chain/include/golos/chain/database.hpp

@@ -58,10 +58,13 @@ namespace golos { namespace chain {
                 _is_generating = p;
             }
 
+            bool is_transit_enabled() const;
+
             bool _is_producing = false;
             bool _is_generating = false;
             bool _is_testing = false;           ///< set for tests to avoid low free memory spam
             bool _log_hardforks = true;
+            uint32_t _fixed_irreversible_block_num = UINT32_MAX;
 
             enum validation_steps {
                 skip_nothing = 0,
@@ -328,6 +331,11 @@ namespace golos { namespace chain {
              */
             fc::signal<void(const signed_transaction &)> on_applied_transaction;
 
+            /**
+             * This signal is emitted when required number of votes is reached to transit to CyberWay
+             */
+            fc::signal<void(const uint32_t, const uint32_t)> transit_to_cyberway;
+
             /**
              *  Emitted After a block has been applied and committed.  The callback
              *  should not yield and should execute quickly.
@@ -581,6 +589,8 @@ namespace golos { namespace chain {
 
             void update_witness_schedule4();
 
+            void process_transit_to_cyberway(const signed_block& b, uint32_t skip);
+
             void update_median_witness_props();
 
             void clear_null_account_balance();

libraries/chain/include/golos/chain/global_property_object.hpp

@@ -144,6 +144,9 @@ namespace golos {
             uint32_t vote_regeneration_per_day = 40;
 
             uint16_t custom_ops_bandwidth_multiplier = STEEMIT_CUSTOM_OPS_BANDWIDTH_MULTIPLIER;
+
+            uint32_t transit_block_num = UINT32_MAX;
+            fc::array<account_name_type, STEEMIT_MAX_WITNESSES> transit_witnesses;
         };
 
         typedef multi_index_container <
@@ -189,5 +192,7 @@ FC_REFLECT((golos::chain::dynamic_global_property_object),
                 (vote_regeneration_per_day)
                 (custom_ops_bandwidth_multiplier)
                 (is_forced_min_price)
+                (transit_block_num)
+                (transit_witnesses)
 )
 CHAINBASE_SET_INDEX_TYPE(golos::chain::dynamic_global_property_object, golos::chain::dynamic_global_property_index)

libraries/chain/include/golos/chain/steem_evaluator.hpp

@@ -55,6 +55,7 @@ namespace golos { namespace chain {
         DEFINE_EVALUATOR(break_free_referral)
         DEFINE_EVALUATOR(delegate_vesting_shares_with_interest)
         DEFINE_EVALUATOR(reject_vesting_shares_delegation)
+        DEFINE_EVALUATOR(transit_to_cyberway)
 
         class proposal_create_evaluator: public evaluator_impl<proposal_create_evaluator> {
         public:

libraries/chain/include/golos/chain/witness_objects.hpp

@@ -115,6 +115,8 @@ namespace golos { namespace chain {
 
         hardfork_version hardfork_version_vote;
         time_point_sec hardfork_time_vote = STEEMIT_GENESIS_TIME;
+
+        time_point_sec transit_to_cyberway_vote = STEEMIT_GENESIS_TIME;
     };
 
 
@@ -247,7 +249,7 @@ FC_REFLECT(
     (golos::chain::witness_object),
     (id)(owner)(created)(url)(votes)(schedule)(virtual_last_update)(virtual_position)(virtual_scheduled_time)(total_missed)
     (last_aslot)(last_confirmed_block_num)(pow_worker)(signing_key)(props)(sbd_exchange_rate)(last_sbd_exchange_update)
-    (last_work)(running_version)(hardfork_version_vote)(hardfork_time_vote))
+    (last_work)(running_version)(hardfork_version_vote)(hardfork_time_vote)(transit_to_cyberway_vote))
 
 CHAINBASE_SET_INDEX_TYPE(golos::chain::witness_object, golos::chain::witness_index)
 

libraries/protocol/include/golos/protocol/config.hpp

@@ -49,7 +49,7 @@
 #define STEEMIT_BLOCKS_PER_YEAR                 (365*24*60*60/STEEMIT_BLOCK_INTERVAL)
 #define STEEMIT_BLOCKS_PER_DAY                  (24*60*60/STEEMIT_BLOCK_INTERVAL)
 #define STEEMIT_START_VESTING_BLOCK             (STEEMIT_BLOCKS_PER_DAY / 512)
-#define STEEMIT_START_MINER_VOTING_BLOCK        (60*10/STEEMIT_BLOCK_INTERVAL)
+#define STEEMIT_START_MINER_VOTING_BLOCK        (60/STEEMIT_BLOCK_INTERVAL)
 #define STEEMIT_FIRST_CASHOUT_TIME              (fc::time_point_sec(1476788400 + STEEMIT_BLOCK_INTERVAL))
 
 #define STEEMIT_INIT_MINER_NAME                 "cyberfounder"
@@ -61,6 +61,7 @@
 #define STEEMIT_MAX_MINER_WITNESSES             1
 #define STEEMIT_MAX_RUNNER_WITNESSES            1
 #define STEEMIT_MAX_WITNESSES                   (STEEMIT_MAX_VOTED_WITNESSES+STEEMIT_MAX_MINER_WITNESSES+STEEMIT_MAX_RUNNER_WITNESSES) /// 21 is more than enough
+#define STEEMIT_TRANSIT_REQUIRED_WITNESSES      1 // 16 from top19 -> This guarantees 75% participation on all subsequent rounds.
 #define STEEMIT_HARDFORK_REQUIRED_WITNESSES     1 // 17 of the 20 dpos witnesses (19 elected and 1 virtual time) required for hardfork. This guarantees 75% participation on all subsequent rounds.
 #define STEEMIT_MAX_TIME_UNTIL_EXPIRATION       (60*60) // seconds,  aka: 1 hour
 #define STEEMIT_MAX_MEMO_SIZE                   2048
@@ -293,6 +294,7 @@
 #define STEEMIT_MAX_MINER_WITNESSES             1
 #define STEEMIT_MAX_RUNNER_WITNESSES            1
 #define STEEMIT_MAX_WITNESSES                   (STEEMIT_MAX_VOTED_WITNESSES+STEEMIT_MAX_MINER_WITNESSES+STEEMIT_MAX_RUNNER_WITNESSES) /// 21 is more than enough
+#define STEEMIT_TRANSIT_REQUIRED_WITNESSES      16 // 16 from top19 -> This guarantees 75% participation on all subsequent rounds.
 #define STEEMIT_HARDFORK_REQUIRED_WITNESSES     17 // 17 of the 20 dpos witnesses (19 elected and 1 virtual time) required for hardfork. This guarantees 75% participation on all subsequent rounds.
 #define STEEMIT_MAX_TIME_UNTIL_EXPIRATION       (60*60) // seconds,  aka: 1 hour
 #define STEEMIT_MAX_MEMO_SIZE                   2048