Skip to content

Commit ba8eb4d

Browse files
Adam Rainegstepniewski-google
authored andcommitted
Fix display override resource access
1 parent 8b7ede7 commit ba8eb4d

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

androidbrowserhelper/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ plugins {
2222
// Before 2.6.1, the version code was unused and was kept at 1.
2323
// This is now being used to report metrics, and should be bumped with
2424
// every version bump.
25-
def VERSION = "2.7.0-alpha01";
26-
def VERSION_CODE = 3;
25+
def VERSION = "2.7.0-alpha02";
26+
def VERSION_CODE = 4;
2727

2828
android {
2929
namespace "com.google.androidbrowserhelper"

androidbrowserhelper/src/main/java/com/google/androidbrowserhelper/trusted/LauncherActivityMetadata.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ private LauncherActivityMetadata(@NonNull Bundle metaData, @NonNull Resources re
234234
}
235235
fallbackStrategyType = metaData.getString(METADATA_FALLBACK_STRATEGY);
236236
displayMode = getDisplayMode(metaData.getString(METADATA_DISPLAY_MODE), /* includeExperimental= */ false);
237-
displayOverrideList = getDisplayOverride(metaData);
237+
displayOverrideList = getDisplayOverride(metaData, resources);
238238
screenOrientation = getOrientation(metaData.getString(METADATA_SCREEN_ORIENTATION));
239239
int shareTargetId = metaData.getInt(METADATA_SHARE_TARGET, 0);
240240
shareTarget = shareTargetId == 0 ? null : resources.getString(shareTargetId);
@@ -300,12 +300,14 @@ private static TrustedWebActivityDisplayMode getDisplayMode(String displayMode,
300300
return new TrustedWebActivityDisplayMode.DefaultMode();
301301
}
302302

303-
private static List<TrustedWebActivityDisplayMode> getDisplayOverride(@NonNull Bundle metaData) {
304-
String[] displayOverrideStringArray = metaData.getStringArray(METADATA_DISPLAY_OVERRIDE);
305-
if (displayOverrideStringArray == null) {
303+
private static List<TrustedWebActivityDisplayMode> getDisplayOverride(@NonNull Bundle metaData, @NonNull Resources resources) {
304+
if (!metaData.containsKey(METADATA_DISPLAY_OVERRIDE)) {
306305
return new ArrayList<>();
307306
}
308307

308+
int displayOverrideResourceId = metaData.getInt(METADATA_DISPLAY_OVERRIDE);
309+
String[] displayOverrideStringArray = resources.getStringArray(displayOverrideResourceId);
310+
309311
List<TrustedWebActivityDisplayMode> displayOverrideList = new ArrayList<>();
310312
for (String displayOverrideString : displayOverrideStringArray) {
311313
displayOverrideList.add(getDisplayMode(displayOverrideString, /* includeExperimental= */ true));

0 commit comments

Comments
 (0)