Skip to content

Commit c5bde95

Browse files
authored
chore: bump to node 18 (#989)
BREAKING CHANGE: minimum supported node is now 18
1 parent 5d30e52 commit c5bde95

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

.github/workflows/ci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ jobs:
2323
uses: actions/checkout@v3
2424
with:
2525
fetch-depth: 0
26-
- name: Use Node.js 16.x
26+
- name: Use Node.js 18.16
2727
uses: actions/setup-node@v3
2828
with:
29-
node-version: 16.x
29+
node-version: 18.16
3030
cache: yarn
3131
- run: yarn install --frozen-lockfile
3232
- run: yarn build
@@ -71,10 +71,10 @@ jobs:
7171
uses: actions/checkout@v3
7272
with:
7373
fetch-depth: 0
74-
- name: Use Node.js 16.x
74+
- name: Use Node.js 18.16
7575
uses: actions/setup-node@v3
7676
with:
77-
node-version: 16.x
77+
node-version: 18.16
7878
cache: yarn
7979
- name: Configure Environment
8080
run: |-

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
- uses: actions/checkout@v3
2121
- uses: actions/setup-node@v3
2222
with:
23-
node-version: 16
23+
node-version: 18
2424
- run: npm install && npm install -g @lhci/[email protected]
2525
- run: npm run build
2626
- run: lhci autorun

docs/recipes/docker-client/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16-bullseye-slim
1+
FROM node:18-bullseye-slim
22

33
# Set variable so puppeteer will not try to download chromium
44
ENV PUPPETEER_SKIP_DOWNLOAD=true

docs/recipes/docker-server/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:16-bullseye-slim
1+
FROM node:18-bullseye-slim
22

33
# Install utilities
44
RUN apt-get update --fix-missing && apt-get install -y python build-essential && apt-get clean

packages/cli/test/collect-psi.test.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ describe('Lighthouse CI collect CLI using PSI', () => {
6969
`);
7070
expect(stderr).toMatchInlineSnapshot(`
7171
"Error: PSI Failed (UNKNOWN): Oops
72-
at PsiClient.run"
72+
at PsiClient.run
73+
at process.processTicksAndRejections"
7374
`);
7475
expect(status).toEqual(1);
7576
}, 180000);

0 commit comments

Comments
 (0)