clients(devtools): remove insight audits config hack (#16468)

Author: connorjclark

clients/devtools/devtools-entry.js

@@ -21,27 +21,6 @@ import thirdPartyWeb from '../../core/lib/third-party-web.js';
 /** @type {BufferConstructor} */
 globalThis.Buffer = Buffer;
 
-// TODO: Remove this when insights aren't hidden by default
-const insightAuditIds = [
-  'cache-insight',
-  'cls-culprits-insight',
-  'document-latency-insight',
-  'dom-size-insight',
-  'duplicated-javascript-insight',
-  'font-display-insight',
-  'forced-reflow-insight',
-  'image-delivery-insight',
-  'interaction-to-next-paint-insight',
-  'lcp-discovery-insight',
-  'lcp-phases-insight',
-  'legacy-javascript-insight',
-  'modern-http-insight',
-  'network-dependency-tree-insight',
-  'render-blocking-insight',
-  'third-parties-insight',
-  'viewport-insight',
-];
-
 /**
  * Returns a config, which runs only certain categories.
  * Varies the config to use based on device.
@@ -70,13 +49,6 @@ function createConfig(categoryIDs, device) {
   return {
     extends: 'lighthouse:default',
     settings,
-    categories: {
-      // @ts-ignore: `title` is required in CategoryJson. setting to the same value as the default
-      // config is awkward - easier to omit the property here. Will defer to default config.
-      'performance': {
-        auditRefs: insightAuditIds.map(id => ({id, weight: 0, group: 'insights'})),
-      },
-    },
   };
 }
 

core/scripts/generate-insight-audits.js

@@ -155,13 +155,3 @@ allAuditIds.sort();
 
   fs.writeFileSync(experimentalConfigPath, experimentalConfigText);
 }
-
-{
-  const devtoolsEntryPath = `${LH_ROOT}/clients/devtools/devtools-entry.js`;
-  let devtoolsEntryText = fs.readFileSync(devtoolsEntryPath, 'utf-8');
-
-  const auditRefListCode = allAuditIds.map(id => `  '${id}',`).join('\n');
-  devtoolsEntryText = insert(devtoolsEntryText, 'insightAuditIds = [\n', '\n]', auditRefListCode);
-
-  fs.writeFileSync(devtoolsEntryPath, devtoolsEntryText);
-}