fix: blocking link async and time ms bugs (#963)

Author: patrickhulce

lighthouse-cli/test/fixtures/dobetterweb/dbw_partial_a.html

@@ -0,0 +1,18 @@
+<!--
+ * Copyright 2016 Google Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+-->
+<div>
+  Blocking content
+</div>

lighthouse-cli/test/fixtures/dobetterweb/dbw_partial_b.html

@@ -0,0 +1,18 @@
+<!--
+ * Copyright 2016 Google Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+-->
+<div>
+  Async content
+</div>

lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html

@@ -27,6 +27,8 @@
 <template id="links-blocking-first-paint-tmpl">
   <link rel="stylesheet" href="./dbw_tester.css">
   <link rel="stylesheet" href="./dbw_disabled.css" disabled>
+  <link rel="import" href="./dbw_partial_a.html">
+  <link rel="import" href="./dbw_partial_b.html" async>
 </template>
 
 <style>

lighthouse-core/gather/gatherers/dobetterweb/links-blocking-first-paint.js

@@ -31,7 +31,7 @@ function collectLinksThatBlockFirstPaint() {
           // https://www.w3.org/TR/html-imports/#dfn-import-async-attribute
           const blockingStylesheet = (link.rel === 'stylesheet' &&
               window.matchMedia(link.media).matches && !link.disabled);
-          const blockingImport = link.rel === 'import' && link.hasAttribute('async');
+          const blockingImport = link.rel === 'import' && !link.hasAttribute('async');
           return blockingStylesheet || blockingImport;
         })
         .map(link => {
@@ -66,7 +66,7 @@ class LinksBlockingFirstPaint extends Gatherer {
   }
 
   _formatMS(info) {
-    return Math.round((info.endTime - info.startTime) * 100) / 100;
+    return Math.round((info.endTime - info.startTime) * 1000);
   }
 
   afterPass(options, tracingData) {

lighthouse-core/test/gather/gatherers/dobetterweb/links-blocking-first-paint-test.js

@@ -57,7 +57,7 @@ describe('First paint blocking links', () => {
     return assert.equal(linksBlockingFirstPaint._formatMS({
       startTime: 0.888,
       endTime: 0.999
-    }), 0.11);
+    }), 111);
   });
 
   it('return filtered link', () => {