Skip to content

Conversation

@camillobruni
Copy link
Collaborator

  • Implement npm run build in script/build.mjs
  • Copy script/helper.mjs from JetStream

@camillobruni camillobruni requested a review from danleh December 17, 2025 12:11
Copy link
Collaborator

@danleh danleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits (Sorry for the late reply, I lost track of this over the Christmas break.)

@@ -0,0 +1,19 @@
import {defaultSuites} from "../resources/default-tests.mjs"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a copyright header for BSD here:

// Copyright 2026 Google LLC
//
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file or at
// https://developers.google.com/open-source/licenses/bsd

}

for (const workloadDir of workloadDirs) {
await logGroup(`BUILDING:${workloadDir}`, () => buildWorkload(workloadDir));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: space after BUILDING:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants