From f63634f94a3888eeb06d0e6d11bb0ac3d26adb15 Mon Sep 17 00:00:00 2001 From: Ujjwaljain16 Date: Fri, 27 Mar 2026 17:32:08 +0530 Subject: [PATCH 1/2] fix(precaching): align CleanupResult with runtime and keep alias --- .../workbox-precaching/src/PrecacheController.ts | 5 ++++- packages/workbox-precaching/src/_types.ts | 13 ++++++++++--- .../sw/test-PrecacheController.mjs | 8 ++++++++ 3 files changed, 22 insertions(+), 4 deletions(-) diff --git a/packages/workbox-precaching/src/PrecacheController.ts b/packages/workbox-precaching/src/PrecacheController.ts index bb7f97e59..5573fb0fa 100644 --- a/packages/workbox-precaching/src/PrecacheController.ts +++ b/packages/workbox-precaching/src/PrecacheController.ts @@ -264,7 +264,10 @@ class PrecacheController { printCleanupDetails(deletedURLs); } - return {deletedURLs}; + return { + deletedURLs, + deletedCacheRequests: deletedURLs, + }; }); } diff --git a/packages/workbox-precaching/src/_types.ts b/packages/workbox-precaching/src/_types.ts index 506d1bc23..abc7cb9a6 100644 --- a/packages/workbox-precaching/src/_types.ts +++ b/packages/workbox-precaching/src/_types.ts @@ -14,7 +14,12 @@ export interface InstallResult { } export interface CleanupResult { - deletedCacheRequests: string[]; + deletedURLs: string[]; + /** + * @deprecated Use `deletedURLs` instead. + * TODO: Remove in the next major release. + */ + deletedCacheRequests?: string[]; } export declare interface PrecacheEntry { @@ -51,8 +56,10 @@ export type urlManipulation = ({url}: {url: URL}) => URL[]; /** * @typedef {Object} CleanupResult - * @property {Array} deletedCacheRequests List of URLs that were deleted - * while cleaning up the cache. + * @property {Array} deletedURLs List of URLs that were deleted while + * cleaning up the cache. + * @property {Array} [deletedCacheRequests] Deprecated alias for + * deletedURLs. * * @memberof workbox-precaching */ diff --git a/test/workbox-precaching/sw/test-PrecacheController.mjs b/test/workbox-precaching/sw/test-PrecacheController.mjs index bd52b19c7..bb15afb2e 100644 --- a/test/workbox-precaching/sw/test-PrecacheController.mjs +++ b/test/workbox-precaching/sw/test-PrecacheController.mjs @@ -834,9 +834,13 @@ describe(`PrecacheController`, function () { activateEvent, ); expect(cleanupDetailsTwo.deletedURLs.length).to.equal(1); + expect(cleanupDetailsTwo.deletedCacheRequests.length).to.equal(1); expect(cleanupDetailsTwo.deletedURLs[0]).to.eql( `${location.origin}/scripts/index.js?__WB_REVISION__=1234`, ); + expect(cleanupDetailsTwo.deletedCacheRequests[0]).to.eql( + `${location.origin}/scripts/index.js?__WB_REVISION__=1234`, + ); const keysTwo = await cache.keys(); expect(keysTwo.length).to.equal(cacheListTwo.length); @@ -894,6 +898,10 @@ describe(`PrecacheController`, function () { `${location.origin}/index.1234.html`, `${location.origin}/scripts/stress.js?test=search&foo=bar&__WB_REVISION__=1234`, ]); + expect(cleanupDetailsTwo.deletedCacheRequests).to.have.members([ + `${location.origin}/index.1234.html`, + `${location.origin}/scripts/stress.js?test=search&foo=bar&__WB_REVISION__=1234`, + ]); const keysTwo = await cache.keys(); expect(keysTwo.length).to.equal(cacheListTwo.length); From b42d7d084175d8e00fc10f2adb5ef513a733227c Mon Sep 17 00:00:00 2001 From: Ujjwaljain16 Date: Fri, 27 Mar 2026 17:37:07 +0530 Subject: [PATCH 2/2] fix(precaching): make CleanupResult alias required --- packages/workbox-precaching/src/_types.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/workbox-precaching/src/_types.ts b/packages/workbox-precaching/src/_types.ts index abc7cb9a6..aa715d2dc 100644 --- a/packages/workbox-precaching/src/_types.ts +++ b/packages/workbox-precaching/src/_types.ts @@ -19,7 +19,7 @@ export interface CleanupResult { * @deprecated Use `deletedURLs` instead. * TODO: Remove in the next major release. */ - deletedCacheRequests?: string[]; + deletedCacheRequests: string[]; } export declare interface PrecacheEntry { @@ -58,7 +58,7 @@ export type urlManipulation = ({url}: {url: URL}) => URL[]; * @typedef {Object} CleanupResult * @property {Array} deletedURLs List of URLs that were deleted while * cleaning up the cache. - * @property {Array} [deletedCacheRequests] Deprecated alias for + * @property {Array} deletedCacheRequests Deprecated alias for * deletedURLs. * * @memberof workbox-precaching