Skip to content

Move from Karma to Playwright? #644

@dfbaskin

Description

@dfbaskin

Since Karma is deprecated, does it make sense to move the tests over to Playwright?

As an example, this is what the tests/two-way-iframe.comlink.test.js test might look like:

import { test } from "@playwright/test";

test.describe("Comlink across iframes", function () {
  test.beforeEach(async ({ page }) => {
    await page.goto("/");
    await page.evaluate(async () => {
      this.ifr = document.createElement("iframe");
      this.ifr.sandbox.add("allow-scripts", "allow-same-origin");
      this.ifr.src = "/tests/fixtures/two-way-iframe.html";
      document.body.appendChild(this.ifr);
      await new Promise((resolve) => (this.ifr.onload = resolve));
    });
  });

  test.afterEach(async ({ page }) => {
    await page.evaluate(() => {
      this.ifr.remove();
    });
  });

  test("can communicate both ways", async ({ page }) => {
    const { value, called } = await page.evaluate(async () => {
      const Comlink = await import("/dist/esm/comlink.mjs");
      let called = false;
      const iframe = Comlink.windowEndpoint(this.ifr.contentWindow);
      Comlink.expose((a) => {
        called = true;
        return ++a;
      }, iframe);
      const proxy = Comlink.wrap(iframe);
      const value = await proxy(1, 3);
      return {
        value,
        called,
      };
    });
    test.expect(value).toEqual(5);
    test.expect(called).toEqual(true);
  });
});

If this move makes sense, I could submit a PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions