New version with better error messages

Author: tomayac

content_script.js

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 ((browser) => {
-
   let DEBUG = false;
 
   const log = (...args) => {
@@ -75,7 +74,7 @@
       1: 'INVALID_SELECTION: ❌ The selected text is too short or does not contain enough valid words. Please choose a longer or more specific phrase.',
       2: 'AMBIGUOUS:❌ The selected text appears multiple times on this page and no unique link could be created. Try selecting a different text segment.',
       3: 'TIMEOUT: ⏳ The process took too long. This may be due to a large page size or slow browser performance. Try selecting a different text segment.',
-      4: 'EXECUTION_FAILED: ⚠️ An unexpected error occurred while generating the link.
+      4: 'EXECUTION_FAILED: ⚠️ An unexpected error occurred while generating the link.',
     };
 
     window.queueMicrotask(() => {

fragment-generation-utils.js

@@ -265,6 +265,26 @@ const makeTextNodeWalker = range => {
   return walker;
 };
 
+/**
+ * Helper function to check if the element has attribute `hidden="until-found"`.
+ * @param {Element} node - the element to evaluate
+ * @return {Boolean} - true if the element has attribute `hidden="until-found"`
+ */
+const isHiddenUntilFound = elt => {
+  if (elt.hidden === 'until-found') {
+    return true;
+  }
+  // Workaround for WebKit. See https://bugs.webkit.org/show_bug.cgi?id=238266
+  const attributes = elt.attributes;
+  if (attributes && attributes['hidden']) {
+    const value = attributes['hidden'].value;
+    if (value === 'until-found') {
+      return true;
+    }
+  }
+  return false;
+};
+
 /**
  * Helper function to calculate the visibility of a Node based on its CSS
  * computed style. This function does not take into account the visibility of
@@ -283,6 +303,9 @@ const isNodeVisible = node => {
   let elt = node;
   while (elt != null && !(elt instanceof HTMLElement)) elt = elt.parentNode;
   if (elt != null) {
+    if (isHiddenUntilFound(elt)) {
+      return true;
+    }
     const nodeStyle = window.getComputedStyle(elt);
     // If the node is not rendered, just skip it.
     if (nodeStyle.visibility === 'hidden' || nodeStyle.display === 'none' || parseInt(nodeStyle.height, 10) === 0 || parseInt(nodeStyle.width, 10) === 0 || parseInt(nodeStyle.opacity, 10) === 0) {

manifest.json

@@ -1,7 +1,7 @@
 {
   "name": "__MSG_extension_name__",
   "short_name": "__MSG_extension_short_name__",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "__MSG_extension_description__",
   "background": {
     "service_worker": "service_worker.js",