Skip to content

Commit 1742a0f

Browse files
Merge pull request #341 from Shubha-accenture/bug-fix/create-runtime-label-issue
Bug fix/create runtime template widget getting blank on jupyter 3.x
2 parents 7586abe + 567ada8 commit 1742a0f

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ classifiers = [
2424
dependencies = [
2525
"jupyter_server>=2.7.3,<3",
2626
"cachetools>=4.2.4",
27-
"google-cloud-jupyter-config>=0.0.10",
27+
"google-cloud-jupyter-config>=0.0.11",
2828
"kernels-mixer>=0.0.13",
2929
"pendulum>=3.0.0",
3030
"pydantic~=1.10.0",

src/jobs/labelProperties.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ function LabelProperties({
228228
/>
229229
</div>
230230

231-
{labelDetailUpdated[index].split(':')[0] === '' &&
231+
{labelDetailUpdated[index]?.split(':')[0] === '' &&
232232
labelDetailUpdated[index] !== '' &&
233233
duplicateKeyError !== index ? (
234234
<div role="alert" className="error-key-parent">

src/runtime/createRunTime.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -286,12 +286,12 @@ function CreateRunTime({
286286
}
287287
];
288288

289-
const updateLightningEngineProperty = () => {
289+
const updateLightningEngineProperty = (currentOthersList = othersList) => {
290290
const lightningProperty = DATAPROC_LIGHTNING_ENGINE_PROPERTY + ":" + (lightningEngineEnabled
291291
? 'lightningEngine'
292292
: 'default');
293293

294-
const updatedProperties = [lightningProperty, ...othersList];
294+
const updatedProperties = [lightningProperty, ...currentOthersList];
295295
setPropertyDetailUpdated(updatedProperties);
296296
return updatedProperties;
297297
}
@@ -318,7 +318,7 @@ function CreateRunTime({
318318
listNetworksAPI();
319319
listKeyRingsAPI();
320320
runtimeSharedProject();
321-
updateLightningEngineProperty();
321+
updateLightningEngineProperty(othersList);
322322
} else {
323323
setConfigLoading(false);
324324
}

0 commit comments

Comments
 (0)