Skip to content

Commit 44f535f

Browse files
committed
Remove irrelevant IDEs
1 parent 7e247af commit 44f535f

2 files changed

Lines changed: 19 additions & 34 deletions

File tree

google/cloud/dataproc_spark_connect/environment.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,6 @@ def is_hex() -> bool:
9595
return os.getenv("HEX_PROJECT_ID") is not None
9696

9797

98-
def is_jetski() -> bool:
99-
"""True if running in JetSki."""
100-
return os.getenv("JETSKI_VERSION") is not None
101-
102-
10398
def is_polynote() -> bool:
10499
"""True if running in Polynote."""
105100
return os.getenv("POLYNOTE_VERSION") is not None
@@ -152,14 +147,13 @@ def get_client_environment_label() -> str:
152147
9. GitHub Codespaces ("codespaces")
153148
10. Google Cloud Shell ("cloud-shell")
154149
11. Hex ("hex")
155-
12. JetSki ("jetski")
156-
13. Polynote ("polynote")
157-
14. VS Code ("vscode")
158-
15. JetBrains IDE ("jetbrains")
159-
16. Spyder ("spyder")
160-
17. Eclipse ("eclipse")
161-
18. Jupyter ("jupyter")
162-
19. Unknown ("unknown")
150+
12. Polynote ("polynote")
151+
13. VS Code ("vscode")
152+
14. JetBrains IDE ("jetbrains")
153+
15. Spyder ("spyder")
154+
16. Eclipse ("eclipse")
155+
17. Jupyter ("jupyter")
156+
18. Unknown ("unknown")
163157
"""
164158
checks: List[Tuple[Callable[[], bool], str]] = [
165159
(is_colab_enterprise, "colab-enterprise"),
@@ -173,7 +167,6 @@ def get_client_environment_label() -> str:
173167
(is_codespaces, "codespaces"),
174168
(is_cloud_shell, "cloud-shell"),
175169
(is_hex, "hex"),
176-
(is_jetski, "jetski"),
177170
(is_polynote, "polynote"),
178171
(is_vscode, "vscode"),
179172
(is_jetbrains_ide, "jetbrains"),

tests/unit/test_environment.py

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,6 @@ def test_is_hex_false(self):
144144
os.environ.pop("HEX_PROJECT_ID", None)
145145
self.assertFalse(environment.is_hex())
146146

147-
def test_is_jetski_true(self):
148-
os.environ["JETSKI_VERSION"] = "1.0"
149-
self.assertTrue(environment.is_jetski())
150-
151-
def test_is_jetski_false(self):
152-
os.environ.pop("JETSKI_VERSION", None)
153-
self.assertFalse(environment.is_jetski())
154-
155147
def test_is_polynote_true(self):
156148
os.environ["POLYNOTE_VERSION"] = "1.0"
157149
self.assertTrue(environment.is_polynote())
@@ -170,6 +162,14 @@ def test_is_eclipse_false(self):
170162
os.environ.pop(k)
171163
self.assertFalse(environment.is_eclipse())
172164

165+
def test_is_antigravity_true(self):
166+
os.environ["ANTIGRAVITY_IDE"] = "1.0"
167+
self.assertTrue(environment.is_antigravity())
168+
169+
def test_is_antigravity_false(self):
170+
os.environ.pop("ANTIGRAVITY_IDE", None)
171+
self.assertFalse(environment.is_antigravity())
172+
173173
def test_is_jetbrains_ide_true(self):
174174
os.environ["TERMINAL_EMULATOR"] = "JetBrains term"
175175
self.assertTrue(environment.is_jetbrains_ide())
@@ -235,10 +235,6 @@ def test_is_jetbrains_ide_false_env_var_not_jetbrains(self):
235235
"google.cloud.dataproc_spark_connect.environment.is_hex",
236236
return_value=False,
237237
)
238-
@mock.patch(
239-
"google.cloud.dataproc_spark_connect.environment.is_jetski",
240-
return_value=False,
241-
)
242238
@mock.patch(
243239
"google.cloud.dataproc_spark_connect.environment.is_polynote",
244240
return_value=False,
@@ -259,6 +255,10 @@ def test_is_jetbrains_ide_false_env_var_not_jetbrains(self):
259255
"google.cloud.dataproc_spark_connect.environment.is_eclipse",
260256
return_value=False,
261257
)
258+
@mock.patch(
259+
"google.cloud.dataproc_spark_connect.environment.is_antigravity",
260+
return_value=False,
261+
)
262262
@mock.patch(
263263
"google.cloud.dataproc_spark_connect.environment.is_jupyter",
264264
return_value=False,
@@ -379,10 +379,6 @@ def test_get_client_environment_label_kaggle(self, *mocks):
379379
"google.cloud.dataproc_spark_connect.environment.is_hex",
380380
return_value=False,
381381
)
382-
@mock.patch(
383-
"google.cloud.dataproc_spark_connect.environment.is_jetski",
384-
return_value=False,
385-
)
386382
@mock.patch(
387383
"google.cloud.dataproc_spark_connect.environment.is_polynote",
388384
return_value=False,
@@ -441,10 +437,6 @@ def test_get_client_environment_label_vscode(self, *mocks):
441437
"google.cloud.dataproc_spark_connect.environment.is_hex",
442438
return_value=False,
443439
)
444-
@mock.patch(
445-
"google.cloud.dataproc_spark_connect.environment.is_jetski",
446-
return_value=False,
447-
)
448440
@mock.patch(
449441
"google.cloud.dataproc_spark_connect.environment.is_polynote",
450442
return_value=False,

0 commit comments

Comments
 (0)