Skip to content

Commit 6f47f7f

Browse files
Simplifying integration test configuration
1 parent eb62065 commit 6f47f7f

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

spark-bigquery-connector-common/src/test/java/com/google/cloud/spark/bigquery/acceptance/AcceptanceTestConstants.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,17 @@
1515
*/
1616
package com.google.cloud.spark.bigquery.acceptance;
1717

18+
import com.google.cloud.ServiceOptions;
1819
import com.google.common.base.Preconditions;
20+
import java.util.Optional;
1921

2022
public class AcceptanceTestConstants {
2123

2224
public static final String REGION = "us-west1";
2325
public static final String DATAPROC_ENDPOINT = REGION + "-dataproc.googleapis.com:443";
2426
public static final String PROJECT_ID =
25-
Preconditions.checkNotNull(
26-
System.getenv("GOOGLE_CLOUD_PROJECT"),
27-
"Please set the 'GOOGLE_CLOUD_PROJECT' environment variable");
27+
Optional.ofNullable(System.getenv("GOOGLE_CLOUD_PROJECT"))
28+
.orElse(ServiceOptions.getDefaultProjectId());
2829
public static final String SERVERLESS_NETWORK_URI =
2930
Preconditions.checkNotNull(
3031
System.getenv("SERVERLESS_NETWORK_URI"),

spark-bigquery-connector-common/src/test/java/com/google/cloud/spark/bigquery/integration/TestConstants.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import static org.apache.spark.sql.types.DataTypes.StringType;
3333
import static org.apache.spark.sql.types.DataTypes.TimestampType;
3434

35+
import com.google.cloud.ServiceOptions;
3536
import com.google.cloud.spark.bigquery.integration.model.ColumnOrderTestClass;
3637
import com.google.cloud.spark.bigquery.integration.model.NumStruct;
3738
import com.google.cloud.spark.bigquery.integration.model.StringStruct;
@@ -43,6 +44,7 @@
4344
import java.sql.Timestamp;
4445
import java.util.Arrays;
4546
import java.util.List;
47+
import java.util.Optional;
4648
import java.util.TimeZone;
4749
import java.util.stream.Collectors;
4850
import java.util.stream.Stream;
@@ -73,9 +75,8 @@ public class TestConstants {
7375
"bigquery-public-data.wikipedia.pageviews_2021";
7476
static final long SHAKESPEARE_TABLE_NUM_ROWS = 164656L;
7577
static final String PROJECT_ID =
76-
Preconditions.checkNotNull(
77-
System.getenv("GOOGLE_CLOUD_PROJECT"),
78-
"Please set the GOOGLE_CLOUD_PROJECT env variable");
78+
Optional.ofNullable(System.getenv("GOOGLE_CLOUD_PROJECT"))
79+
.orElse(ServiceOptions.getDefaultProjectId());
7980
static final String TEMPORARY_GCS_BUCKET_ENV_VARIABLE = "TEMPORARY_GCS_BUCKET";
8081
static final String BIGLAKE_CONNECTION_ID_ENV_VARIABLE = "BIGLAKE_CONNECTION_ID";
8182
static final String TEMPORARY_GCS_BUCKET =

0 commit comments

Comments
 (0)