Merge pull request #3004 from GoogleCloudPlatform/release-candidate

Release v1.39.0

Author: rohitramu

.github/dependabot.yml

@@ -23,11 +23,14 @@ updates:
   - go
   - release-chore
   schedule:
-    interval: weekly
+    interval: monthly
     day: monday
     time: "03:00"
     timezone: America/Los_Angeles
   target-branch: develop
+  ignore:
+  - dependency-name: "google.golang.org/api"
+
 - package-ecosystem: pip
   directory: /community/front-end/ofe/
   labels:
@@ -45,3 +48,18 @@ updates:
   # Disable version updates, do security updates only
   # See https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file
   open-pull-requests-limit: 0
+- package-ecosystem: pip
+  directory: /community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/
+  labels:
+  - dependencies
+  - python
+  - release-chore
+  schedule:
+    interval: weekly
+    day: monday
+    time: "03:00"
+    timezone: America/Los_Angeles
+  target-branch: develop
+  # Disable version updates, do security updates only
+  # See https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file
+  open-pull-requests-limit: 0

.github/pull_request_template.md

@@ -1,5 +1,7 @@
 ### Submission Checklist
 
+NOTE: Community submissions can take up to 2 weeks to be reviewed.
+
 Please take the following actions before submitting this pull request.
 
 * Fork your PR branch from the Toolkit "develop" branch (not main)

.github/workflows/pr-precommit.yml

@@ -38,10 +38,6 @@ jobs:
         python-version: '3.10'
         check-latest: true
         cache: 'pip'
-    - run: >
-        pip install
-        -r community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/requirements.txt
-        -r community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/requirements.txt
     - uses: actions/setup-go@v5
       with:
         go-version: '1.22'

.pre-commit-config.yaml

@@ -76,7 +76,7 @@ repos:
     require_serial: true
   - id: pytest-check
     name: pytest-check
-    entry: pytest
+    entry: python -m pytest
     language: system
     types: [python]
     pass_filenames: false

CONTRIBUTING.md

@@ -20,7 +20,11 @@ again.
 All submissions, including submissions by project members, require review. We
 use GitHub pull requests for this purpose. Consult
 [GitHub Help](https://help.github.com/articles/about-pull-requests/) for more
-information on using pull requests.
+information on pull requests.
+
+### Standard PR Response Times
+
+Community submissions can take up to 2 weeks to be reviewed.
 
 ## Community Guidelines
 

Makefile

@@ -69,6 +69,8 @@ install-dev-deps: warn-terraform-version warn-packer-version check-pre-commit ch
 	go install mvdan.cc/sh/v3/cmd/shfmt@latest
 	go install golang.org/x/tools/cmd/goimports@latest
 	go install honnef.co/go/tools/cmd/staticcheck@latest
+	pip install -r community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/requirements.txt
+	pip install -r community/modules/scheduler/schedmd-slurm-gcp-v6-controller/modules/slurm_files/scripts/tests/requirements.txt
 
 # RULES SUPPORTING THE ABOVE
 

cmd/root.go

@@ -53,7 +53,7 @@ HPC deployments on the Google Cloud Platform.`,
 				logging.Fatal("cmd.Help function failed: %s", err)
 			}
 		},
-		Version:     "v1.38.0",
+		Version:     "v1.39.0",
 		Annotations: annotation,
 	}
 )

community/examples/AMD/README.md

@@ -53,10 +53,10 @@ using the `compute` partition, you may ignore its quota requirements.
 
 ### Deploying the Blueprint
 
-Use `ghpc` to provision the blueprint, supplying your project ID:
+Use `gcluster` to provision the blueprint, supplying your project ID:
 
 ```shell
-ghpc create --vars project_id=<<PROJECT_ID>> hpc-amd-slurm.yaml
+gcluster create --vars project_id=<<PROJECT_ID>> hpc-amd-slurm.yaml
 ```
 
 It will create a directory containing a Terraform module. Follow the printed

community/examples/flux-framework/README.md

@@ -26,15 +26,15 @@ Toolkit guidance to enable [APIs][apis] and establish minimum resource
 
 ### Deploy the flux-framework Cluster
 
-Use `ghcp` to provision the blueprint
+Use `gcluster` to provision the blueprint
 
 ```bash
-ghpc create community/examples/flux-framework --vars project_id=<<PROJECT_ID>>
+gcluster create community/examples/flux-framework --vars project_id=<<PROJECT_ID>>
 ```
 
 This will create a directory containing Terraform modules.
 
-Follow `ghpc` instructions to deploy the cluster
+Follow `gcluster` instructions to deploy the cluster
 
 ```text
 terraform -chdir=flux-fw-cluster/primary init

community/examples/hpc-slurm6-tpu-maxtext.yaml

@@ -72,7 +72,7 @@ deployment_groups:
           python3 MaxText/train.py MaxText/configs/base.yml run_name=<RUN_NAME> base_output_directory=${PWD}/output/ dataset_path=<STORAGE_BUCKET> async_checkpointing=False attention=<ATTENTION> steps=<STEPS>
 
   - id: tpu_nodeset
-    source: ./community/modules/compute/schedmd-slurm-gcp-v6-nodeset-tpu
+    source: community/modules/compute/schedmd-slurm-gcp-v6-nodeset-tpu
     use: [network]
     settings:
       node_type: v4-8
@@ -88,7 +88,7 @@ deployment_groups:
       node_count_dynamic_max: 1
 
   - id: tpu_partition
-    source: ./community/modules/compute/schedmd-slurm-gcp-v6-partition
+    source: community/modules/compute/schedmd-slurm-gcp-v6-partition
     use: [tpu_nodeset]
     settings:
       partition_name: tpu
@@ -110,14 +110,14 @@ deployment_groups:
       is_default: true
 
   - id: slurm_login
-    source: ./community/modules/scheduler/schedmd-slurm-gcp-v6-login
+    source: community/modules/scheduler/schedmd-slurm-gcp-v6-login
     use: [network]
     settings:
       enable_login_public_ips: true
       machine_type: n2-standard-16
 
   - id: slurm_controller
-    source: ./community/modules/scheduler/schedmd-slurm-gcp-v6-controller
+    source: community/modules/scheduler/schedmd-slurm-gcp-v6-controller
     use:
     - tpu_partition
     - compute_partition