Skip to content

Commit 80fe5ae

Browse files
Merge pull request #4769 from ankitkumar-quad/release-pr
Release patch
2 parents 41630ae + 2e7e2f9 commit 80fe5ae

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

modules/compute/gke-node-pool/reservation_definitions.tf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ locals {
2222
input_reservation_projects = [for r in try(var.reservation_affinity.specific_reservations, []) : coalesce(r.project, var.project_id)]
2323
# We, also, remember the suffix "/reservationBlocks/exr-one-block-1" for use elsewhere afterwards
2424
input_reservation_suffixes = [for r in try(var.reservation_affinity.specific_reservations, []) : substr(r.name, length(split("/", r.name)[0]), -1)]
25+
# Adding this variable to by-pass the machine-type validation for TPUs
26+
is_tpu = var.placement_policy.tpu_topology != null
2527
}
2628

2729
data "google_compute_reservation" "specific_reservations" {
@@ -56,9 +58,9 @@ locals {
5658
verified_specific_reservations = [for k, v in data.google_compute_reservation.specific_reservations : v if(v.specific_reservation != null && v.specific_reservation_required == true)]
5759

5860
# Build two maps to be used to compare the VM properties between reservations and the node pool
59-
# Skip this for TPUs
6061
# Validation of only machine-type for CPUs and and both machine-type and guest-accelerators for GPUs
61-
reservation_vm_properties = [for reservation in local.verified_specific_reservations : {
62+
# Skip this for TPUs ( returns an empty list to skip the machine-type validation for aggregate TPU reservations)
63+
reservation_vm_properties = local.is_tpu ? [] : [for reservation in local.verified_specific_reservations : {
6264
"machine_type" : try(reservation.specific_reservation[0].instance_properties[0].machine_type, "")
6365
"guest_accelerators" : local.has_gpu ? ( # Conditional check for GPUs
6466
{ for acc in try(reservation.specific_reservation[0].instance_properties[0].guest_accelerators, []) : acc.accelerator_type => acc.accelerator_count }

0 commit comments

Comments
 (0)