Skip to content

Commit a2185de

Browse files
Merge branch 'main' of https://github.com/GoogleCloudPlatform/dagify into fix/report-gen
2 parents 13090d1 + 513fbbf commit a2185de

File tree

5 files changed

+13
-12
lines changed

5 files changed

+13
-12
lines changed

.github/workflows/python_workflow.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ jobs:
2525
steps:
2626
- uses: actions/checkout@v5
2727
- name: Set up Python 3.10
28-
uses: actions/setup-python@v5
28+
uses: actions/setup-python@v6
2929
with:
30-
python-version: "3.13"
30+
python-version: "3.14"
3131

3232
- name: Install dependencies
3333
run: |

dagify/converter/controlm.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,5 +58,5 @@ def __init__(
5858
convert(self, "control-m", "TASKTYPE", "JOBNAME")
5959
cal_dag_dividers(self)
6060
calc_dag_dependencies(self.uf, "controlm")
61-
generate_airflow_dags(self, "JOBNAME_ORIGINAL")
61+
generate_airflow_dags(self, "JOBNAME")
6262

dagify/converter/uf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def calculate_dag_dependencies_controlm(self):
9696
for obj in self.get_tasks():
9797
for in_conds in obj.get_in_conditions():
9898
if in_conds.get_attribute("NAME") == poutcon.get_attribute("NAME"):
99-
task.add_dependent_task(obj.get_dag_name(), obj.get_attribute("JOBNAME_ORIGINAL"))
99+
task.add_dependent_task(obj.get_dag_name(), obj.get_attribute("JOBNAME"))
100100
return
101101

102102
def generate_dag_dependencies_by_divider(self, dag_divider, task_name):

dagify/converter/yaml_validator/custom_validator.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,19 @@ def _is_valid(self, value):
1414
def fail(self, value):
1515
return f'{value} is not a valid email address.'
1616

17-
17+
#K.S. edit: Removing URL validator for now to avoid broken URL links to crash the tool.
18+
# Additionally, requiring internet access for the tool might not be a good idea.
1819
class URLValidator(Validator):
1920
tag = 'validURL' # This is the tag you use in your schema
2021

2122
def _is_valid(self, value):
2223

23-
try:
24-
response = requests.get(value)
25-
return response.status_code == 200
26-
except requests.exceptions.RequestException as e:
27-
print(f"Error checking URL: {e}")
28-
24+
#try:
25+
# response = requests.get(value)
26+
# return response.status_code == 200
27+
#except requests.exceptions.RequestException as e:
28+
# print(f"Error checking URL: {e}")
29+
return True
2930

3031
# Extend default validators with your custom validators
3132
validators = DefaultValidators.copy()

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ pycodestyle==2.14.0
1111
pyflakes==3.4.0
1212
python-dateutil==2.9.0.post0
1313
pytz==2025.2
14-
PyYAML==6.0.2
14+
PyYAML==6.0.3
1515
six==1.17.0
1616
tzdata==2025.2
1717
yamale==6.0.0

0 commit comments

Comments
 (0)