Skip to content

Commit 48c687c

Browse files
committed
failing test is now passing
1 parent c1b103f commit 48c687c

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

pkg/webhook/validating_admission_policy_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import (
2424
"testing"
2525

2626
"github.com/google/go-cmp/cmp"
27+
"github.com/google/go-cmp/cmp/cmpopts"
2728
admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
2829
corev1 "k8s.io/api/core/v1"
2930
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -158,12 +159,14 @@ func TestValidatingAdmissionPolicy(t *testing.T) {
158159

159160
validator := compilePolicy(policy)
160161

162+
ignoreElapsedField := cmpopts.IgnoreFields(validating.PolicyDecision{}, "Elapsed")
163+
161164
for _, tc := range testCases {
162165
fakeAttr := admission.NewAttributesRecord(tc.pod, nil, schema.GroupVersionKind{}, "", "", schema.GroupVersionResource{}, "", "", nil, false, nil)
163166
fakeVersionedAttr, _ := admission.NewVersionedAttributes(fakeAttr, schema.GroupVersionKind{}, nil)
164167
validateResult := validator.Validate(context.TODO(), fakeVersionedAttr.GetResource(), fakeVersionedAttr, nil, nil, celconfig.RuntimeCELCostBudget, nil)
165168

166-
if diff := cmp.Diff(validateResult, tc.expectedResult); diff != "" {
169+
if diff := cmp.Diff(validateResult, tc.expectedResult, ignoreElapsedField); diff != "" {
167170
t.Errorf("unexpected options args (-got, +want)\n%s", diff)
168171
}
169172
}

0 commit comments

Comments
 (0)