Skip to content

Commit 9e0ddcb

Browse files
committed
restrict sidecar bucket access check for only workload identity
1 parent d18264b commit 9e0ddcb

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

pkg/csi_driver/node.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,9 @@ func (s *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublish
148148
}
149149
klog.V(6).Infof("NodePublishVolume populating identity provider %q in mount options", identityProvider)
150150
fuseMountOptions = joinMountOptions(fuseMountOptions, []string{util.OptInHnw + "=true", util.TokenServerIdentityProviderConst + "=" + identityProvider})
151+
} else if enableSidecarBucketAccessCheckForSidecarVersion {
152+
//Enable sidecar bucket access check only for Workload Identity workloads. This feature consumes additional quota for Host Network pods as we do not have token caching.
153+
fuseMountOptions = joinMountOptions(fuseMountOptions, []string{util.EnableSidecarBucketAccessCheckConst + "=" + strconv.FormatBool(s.driver.config.EnableSidecarBucketAccessCheck)})
151154
}
152155

153156
if enableSidecarBucketAccessCheckForSidecarVersion {
@@ -161,7 +164,6 @@ func (s *nodeServer) NodePublishVolume(ctx context.Context, req *csi.NodePublish
161164
fuseMountOptions = joinMountOptions(fuseMountOptions, []string{
162165
util.PodNamespaceConst + "=" + vc[VolumeContextKeyPodNamespace],
163166
util.ServiceAccountNameConst + "=" + vc[VolumeContextKeyServiceAccountName],
164-
util.EnableSidecarBucketAccessCheckConst + "=" + strconv.FormatBool(s.driver.config.EnableSidecarBucketAccessCheck),
165167
util.TokenServerIdentityPoolConst + "=" + identityPool})
166168
}
167169

0 commit comments

Comments
 (0)