Skip to content

Commit e8e6b4e

Browse files
committed
Remove Extra tests
1 parent ceb0f85 commit e8e6b4e

File tree

1 file changed

+1
-44
lines changed

1 file changed

+1
-44
lines changed

tools/integration_tests/monitoring/kernel_reader_prom_test.go

Lines changed: 1 addition & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323

2424
"github.com/googlecloudplatform/gcsfuse/v3/tools/integration_tests/util/client"
2525
"github.com/googlecloudplatform/gcsfuse/v3/tools/integration_tests/util/setup"
26-
"github.com/pkg/xattr"
2726
"github.com/stretchr/testify/require"
2827
"github.com/stretchr/testify/suite"
2928
)
@@ -51,51 +50,9 @@ func (p *PromKernelReaderTest) TestKernelReaderMetrics() {
5150
assertNonZeroHistogramMetric(p.T(), "gcs_request_latencies", "gcs_method", "MultiRangeDownloader::Add", p.prometheusPort)
5251
}
5352

54-
func (p *PromKernelReaderTest) TestStatMetrics() {
55-
prometheusPort := p.prometheusPort
56-
57-
_, err := os.Stat(path.Join(testEnv.testDirPath, "hello.txt"))
58-
59-
require.NoError(p.T(), err)
60-
assertNonZeroCountMetric(p.T(), "fs_ops_count", "fs_op", "LookUpInode", prometheusPort)
61-
assertNonZeroHistogramMetric(p.T(), "fs_ops_latency", "fs_op", "LookUpInode", prometheusPort)
62-
assertNonZeroCountMetric(p.T(), "gcs_request_count", "gcs_method", "StatObject", prometheusPort)
63-
assertNonZeroHistogramMetric(p.T(), "gcs_request_latencies", "gcs_method", "StatObject", prometheusPort)
64-
}
65-
66-
func (p *PromKernelReaderTest) TestFsOpsErrorMetrics() {
67-
prometheusPort := p.prometheusPort
68-
69-
_, err := os.Stat(path.Join(testEnv.testDirPath, "non_existent_path.txt"))
70-
71-
require.Error(p.T(), err)
72-
assertNonZeroCountMetric(p.T(), "fs_ops_error_count", "fs_op", "LookUpInode", prometheusPort)
73-
assertNonZeroHistogramMetric(p.T(), "fs_ops_latency", "fs_op", "LookUpInode", prometheusPort)
74-
}
75-
76-
func (p *PromKernelReaderTest) TestListMetrics() {
77-
prometheusPort := p.prometheusPort
78-
79-
_, err := os.ReadDir(testEnv.testDirPath)
80-
81-
require.NoError(p.T(), err)
82-
assertNonZeroCountMetric(p.T(), "fs_ops_count", "fs_op", "ReadDir", prometheusPort)
83-
assertNonZeroCountMetric(p.T(), "fs_ops_count", "fs_op", "OpenDir", prometheusPort)
84-
assertNonZeroCountMetric(p.T(), "gcs_request_count", "gcs_method", "ListObjects", prometheusPort)
85-
assertNonZeroHistogramMetric(p.T(), "gcs_request_latencies", "gcs_method", "ListObjects", prometheusPort)
86-
}
87-
88-
func (p *PromKernelReaderTest) TestSetXAttrMetrics() {
89-
prometheusPort := p.prometheusPort
90-
91-
err := xattr.Set(path.Join(testEnv.testDirPath, "hello.txt"), "alpha", []byte("beta"))
92-
93-
require.Error(p.T(), err)
94-
assertNonZeroCountMetric(p.T(), "fs_ops_error_count", "fs_op", "Others", prometheusPort)
95-
}
96-
9753
func TestPromKernelReaderSuite(t *testing.T) {
9854
ts := &PromKernelReaderTest{}
55+
// ts.suiteName = "TestPromKernelReaderSuite"
9956
flagSets := setup.BuildFlagSets(*testEnv.cfg, testEnv.bucketType, t.Name())
10057
for _, flags := range flagSets {
10158
ts.flags = flags

0 commit comments

Comments
 (0)