Migrated store data to SharedArrayBuffer for utilizing WebWorkers

Author: kyasbal

web/src/app/extensions/public/module.ts

@@ -16,17 +16,12 @@
 
 import { NgModule } from '@angular/core';
 import { KHIExtensionBundle } from '../extension-common/extension';
-import { NodeNameBindingWithPod } from './timeline-navigator-extensions';
 import { Reporter, ConsoleReporter } from 'src/app/common/reporter/reporter';
 
 @NgModule({
   providers: [
-    KHIExtensionBundle.forExtension(initExtension),
+    KHIExtensionBundle.forExtension(() => {}),
     { provide: Reporter, useClass: ConsoleReporter },
   ],
 })
 export class PublicKHIExtension {}
-
-function initExtension(extension: KHIExtensionBundle) {
-  extension.addTimelineNavigatorExtension(new NodeNameBindingWithPod());
-}

web/src/app/parser/core/builder.ts

@@ -63,8 +63,8 @@ export class InspectionDataBuilder {
   private iconAtlasPromise?: Promise<void>;
 
   constructor() {
-    this.logStore = new LogStore(this.internPool, this.styleStore);
-    this.timelineStore = new TimelineStore(
+    this.logStore = LogStore.create(this.internPool, this.styleStore);
+    this.timelineStore = TimelineStore.create(
       this.internPool,
       this.styleStore,
       this.logStore,

web/src/app/services/selection-manager-v2.service.spec.ts

@@ -39,8 +39,8 @@ describe('SelectionManagerV2', () => {
 
     const internPool = InternPoolStore.create();
     const styleStore = new StyleStore();
-    logStore = new LogStore(internPool, styleStore);
-    timelineStore = new TimelineStore(internPool, styleStore, logStore);
+    logStore = LogStore.create(internPool, styleStore);
+    timelineStore = TimelineStore.create(internPool, styleStore, logStore);
 
     styleStore.addSeverities([
       {

web/src/app/store/domain/filter/cel-env.spec.ts

@@ -37,8 +37,8 @@ describe('CELTimelineFilterEnvironment', () => {
     env = new CELTimelineFilterEnvironment();
     internPool = InternPoolStore.create();
     styleStore = new StyleStore();
-    logStore = new LogStore(internPool, styleStore);
-    timelineStore = new TimelineStore(internPool, styleStore, logStore);
+    logStore = LogStore.create(internPool, styleStore);
+    timelineStore = TimelineStore.create(internPool, styleStore, logStore);
   });
 
   it('should successfully compile a valid CEL expression', () => {

web/src/app/store/domain/intern-pool-store.spec.ts

@@ -209,4 +209,41 @@ describe('InternPoolStore', () => {
       sharedStore.addFieldPathSets([{ id: 200, fieldPathStringIds: [10] }]);
     }).toThrowError('Cannot write to a shared read-only InternPoolStore');
   });
+
+  describe('ArrayBuffer fallback when SharedArrayBuffer is unsupported', () => {
+    let originalSharedArrayBuffer: typeof SharedArrayBuffer | undefined;
+
+    beforeEach(() => {
+      originalSharedArrayBuffer = (
+        globalThis as Record<string, typeof SharedArrayBuffer | undefined>
+      )['SharedArrayBuffer'];
+      (globalThis as Record<string, typeof SharedArrayBuffer | undefined>)[
+        'SharedArrayBuffer'
+      ] = undefined;
+    });
+
+    afterEach(() => {
+      (globalThis as Record<string, typeof SharedArrayBuffer | undefined>)[
+        'SharedArrayBuffer'
+      ] = originalSharedArrayBuffer;
+    });
+
+    it('should allocate ArrayBuffer instead of SharedArrayBuffer and perform operations successfully', () => {
+      const fallbackStore = InternPoolStore.create();
+      fallbackStore.addStrings([
+        { id: 10, value: 'fallback-string-1' },
+        { id: 20, value: 'fallback-string-2' },
+      ]);
+
+      expect(fallbackStore.getString(10)).toBe('fallback-string-1');
+      expect(fallbackStore.getString(20)).toBe('fallback-string-2');
+
+      const sharedData = fallbackStore.getSharedData();
+      expect(sharedData.metadataSab instanceof ArrayBuffer).toBeTrue();
+      expect(sharedData.bufferSabs[0] instanceof ArrayBuffer).toBeTrue();
+
+      const reconstructedStore = InternPoolStore.fromSharedData(sharedData);
+      expect(reconstructedStore.getString(10)).toBe('fallback-string-1');
+    });
+  });
 });

web/src/app/store/domain/intern-pool-store.ts

@@ -28,6 +28,8 @@ export interface StringEntryDTO {
   readonly value: string;
 }
 
+import { allocateBuffer, isSharedBuffer } from 'src/app/store/domain/types';
+
 /**
  * Represents an entry defining a set of field path names.
  */
@@ -47,8 +49,8 @@ export interface FieldPathSetEntryDTO {
  * This can be transferred to a WebWorker via postMessage.
  */
 export interface InternPoolSharedData {
-  readonly bufferSabs: readonly SharedArrayBuffer[];
-  readonly metadataSab: SharedArrayBuffer;
+  readonly bufferSabs: readonly (SharedArrayBuffer | ArrayBuffer)[];
+  readonly metadataSab: SharedArrayBuffer | ArrayBuffer;
   readonly capacity: number;
   readonly fieldPathSets: readonly (readonly number[])[];
 }
@@ -65,7 +67,7 @@ export class InternPoolStore {
   /**
    * The SharedArrayBuffers backing the encoded string buffers.
    */
-  private readonly bufferSabs: SharedArrayBuffer[] = [];
+  private readonly bufferSabs: (SharedArrayBuffer | ArrayBuffer)[] = [];
 
   /**
    * Tracks the buffer index for each string ID (1-based index, 0 represents uninitialized).
@@ -85,7 +87,7 @@ export class InternPoolStore {
   /**
    * The single SharedArrayBuffer holding all metadata arrays.
    */
-  private metadataSab: SharedArrayBuffer;
+  private metadataSab: SharedArrayBuffer | ArrayBuffer;
 
   /**
    * Whether this store is read-only (for worker-side decoding).
@@ -121,7 +123,7 @@ export class InternPoolStore {
     this.readOnly = readOnly;
     if (typeof initialCapacityOrSharedData === 'number') {
       const initialCapacity = initialCapacityOrSharedData;
-      this.metadataSab = new SharedArrayBuffer(initialCapacity * 10);
+      this.metadataSab = allocateBuffer(initialCapacity * 10);
       this.bufferIndices = new Uint16Array(
         this.metadataSab,
         0,
@@ -208,7 +210,7 @@ export class InternPoolStore {
         this.maxBufferSize - this.currentOffset < encoded.length
       ) {
         const newSize = Math.max(this.maxBufferSize, encoded.length);
-        const sab = new SharedArrayBuffer(newSize);
+        const sab = allocateBuffer(newSize);
         this.bufferSabs.push(sab);
         this.buffers.push(new Uint8Array(sab));
         this.currentBufferIndex = this.buffers.length - 1;
@@ -261,9 +263,12 @@ export class InternPoolStore {
 
     const buffer = this.buffers[bufferIndex];
     const bytes = buffer.subarray(offset, offset + length);
-    const nonSharedBytes = new Uint8Array(length);
-    nonSharedBytes.set(bytes);
-    return this.decoder.decode(nonSharedBytes);
+    if (isSharedBuffer(bytes.buffer)) {
+      const nonSharedBytes = new Uint8Array(length);
+      nonSharedBytes.set(bytes);
+      return this.decoder.decode(nonSharedBytes);
+    }
+    return this.decoder.decode(bytes);
   }
 
   /**
@@ -310,7 +315,7 @@ export class InternPoolStore {
       newCapacity *= 2;
     }
 
-    const newMetadataSab = new SharedArrayBuffer(newCapacity * 10);
+    const newMetadataSab = allocateBuffer(newCapacity * 10);
     const newBufferIndices = new Uint16Array(newMetadataSab, 0, newCapacity);
     const newOffsets = new Uint32Array(
       newMetadataSab,

web/src/app/store/domain/log-store.spec.ts

@@ -33,7 +33,7 @@ describe('LogStore', () => {
   beforeEach(() => {
     internPool = InternPoolStore.create();
     styleStore = new StyleStore();
-    store = new LogStore(internPool, styleStore);
+    store = LogStore.create(internPool, styleStore);
 
     // Avoid errors of missing keys in basic tests
     styleStore.addSeverities([
@@ -316,4 +316,99 @@ describe('LogStore', () => {
     expect(iteratedLogs[0].id).toBe(1);
     expect(iteratedLogs[1].id).toBe(2);
   });
+
+  it('should restore from shared memory using fromSharedData and enforce readOnly guard', () => {
+    internPool.addStrings([
+      { id: 20, value: 'user' },
+      { id: 21, value: 'alice' },
+    ]);
+    internPool.addFieldPathSets([{ id: 2, fieldPathStringIds: [20] }]);
+    const struct = create(InternedStructSchema, {
+      fieldPathSetId: 2,
+      values: [
+        create(InternedValueSchema, {
+          kind: { case: 'stringValue', value: 21 },
+        }),
+      ],
+    });
+    const rawBody = toBinary(InternedStructSchema, struct);
+
+    const logs: LogDTO[] = [
+      {
+        id: 1,
+        ts: 1000n,
+        logTypeId: 1,
+        severityTypeId: 1,
+        summaryStringId: 1,
+        body: rawBody,
+      },
+    ];
+
+    store.initialize(logs, 1);
+
+    const sharedData = store.getSharedData();
+    const restoredStore = LogStore.fromSharedData(
+      internPool,
+      styleStore,
+      sharedData,
+    );
+
+    expect(restoredStore.count).toBe(1);
+    const restoredLog = restoredStore.getLog(1);
+    expect(restoredLog.id).toBe(1);
+    expect(restoredLog.timestamp).toBe(1000n);
+    expect(restoredLog.body).toEqual({ user: 'alice' });
+
+    expect(() => {
+      restoredStore.initialize(logs, 1);
+    }).toThrowError('Cannot write to a shared read-only LogStore');
+  });
+
+  describe('ArrayBuffer fallback when SharedArrayBuffer is unsupported', () => {
+    let originalSharedArrayBuffer: typeof SharedArrayBuffer | undefined;
+
+    beforeEach(() => {
+      originalSharedArrayBuffer = (
+        globalThis as Record<string, typeof SharedArrayBuffer | undefined>
+      )['SharedArrayBuffer'];
+      (globalThis as Record<string, typeof SharedArrayBuffer | undefined>)[
+        'SharedArrayBuffer'
+      ] = undefined;
+    });
+
+    afterEach(() => {
+      (globalThis as Record<string, typeof SharedArrayBuffer | undefined>)[
+        'SharedArrayBuffer'
+      ] = originalSharedArrayBuffer;
+    });
+
+    it('should allocate ArrayBuffer instead of SharedArrayBuffer and perform operations successfully', () => {
+      const fallbackStore = LogStore.create(internPool, styleStore);
+      const logs: LogDTO[] = [
+        {
+          id: 1,
+          ts: 1000n,
+          logTypeId: 1,
+          severityTypeId: 1,
+          summaryStringId: 1,
+        },
+      ];
+      fallbackStore.initialize(logs, 1);
+
+      expect(fallbackStore.count).toBe(1);
+      const log = fallbackStore.getLog(1);
+      expect(log.id).toBe(1);
+
+      const sharedData = fallbackStore.getSharedData();
+      expect(sharedData.metadataSab instanceof ArrayBuffer).toBeTrue();
+
+      const restoredStore = LogStore.fromSharedData(
+        internPool,
+        styleStore,
+        sharedData,
+      );
+      expect(restoredStore.count).toBe(1);
+      expect(restoredStore.getLog(1).id).toBe(1);
+    });
+  });
 });