agent: ignore empty query (#485)

Author: droot

pkg/agent/conversation.go

@@ -362,6 +362,10 @@ func (c *Agent) Run(ctx context.Context, initialQuery string) error {
 						log.Error(nil, "Received unexpected input from channel", "userInput", userInput)
 						return
 					}
+					if strings.TrimSpace(query.Query) == "" {
+						log.Info("No query provided, skipping agentic loop")
+						continue
+					}
 					c.addMessage(api.MessageSourceUser, api.MessageTypeText, query.Query)
 					// we don't need the agentic loop for meta queries
 					// for ex. model, tools, etc.

pkg/ui/terminal.go

@@ -282,12 +282,20 @@ func (u *TerminalUI) handleMessage(msg *api.Message) {
 				klog.Errorf("Failed to get TTY reader: %v", err)
 				return
 			}
-			fmt.Print("\n>>> ") // Print prompt manually
-			query, err = tReader.ReadString('\n')
-			if err != nil {
-				klog.Errorf("Error reading from TTY: %v", err)
-				u.agent.Input <- fmt.Errorf("error reading from TTY: %w", err)
-				return
+			// keep reading input until we get a non-empty query
+			for {
+				var err error
+				fmt.Print("\n>>> ") // Print prompt manually
+				query, err = tReader.ReadString('\n')
+				if err != nil {
+					klog.Errorf("Error reading from TTY: %v", err)
+					u.agent.Input <- fmt.Errorf("error reading from TTY: %w", err)
+					return
+				}
+				if strings.TrimSpace(query) == "" {
+					continue
+				}
+				break
 			}
 			klog.Infof("Sending TTY input to agent: %q", query)
 			u.agent.Input <- &api.UserInputResponse{Query: query}
@@ -298,21 +306,28 @@ func (u *TerminalUI) handleMessage(msg *api.Message) {
 				u.agent.Input <- fmt.Errorf("error creating readline instance: %w", err)
 				return
 			}
-			rlInstance.SetPrompt(">>> ") // Ensure correct prompt
-			query, err = rlInstance.Readline()
-			if err != nil {
-				klog.Infof("Readline error: %v", err)
-				switch err {
-				case readline.ErrInterrupt: // Handle Ctrl+C
-					u.agent.Input <- io.EOF
-				case io.EOF: // Handle Ctrl+D
-					u.agent.Input <- io.EOF
-				default:
-					u.agent.Input <- err
+			// keep reading input until we get a non-empty query
+			for {
+				rlInstance.SetPrompt(">>> ") // Ensure correct prompt
+				query, err = rlInstance.Readline()
+				if err != nil {
+					klog.Infof("Readline error: %v", err)
+					switch err {
+					case readline.ErrInterrupt: // Handle Ctrl+C
+						u.agent.Input <- io.EOF
+					case io.EOF: // Handle Ctrl+D
+						u.agent.Input <- io.EOF
+					default:
+						u.agent.Input <- err
+					}
+					break
+				}
+				if strings.TrimSpace(query) == "" {
+					continue
 				}
-			} else {
 				klog.Infof("Sending readline input to agent: %q", query)
 				u.agent.Input <- &api.UserInputResponse{Query: query}
+				break
 			}
 		}
 		if query == "clear" || query == "reset" {