Skip to content

storage: add SetResourceIdentityAttributes in update#17768

Merged
BBBmau merged 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:storage-identity-update
May 29, 2026
Merged

storage: add SetResourceIdentityAttributes in update#17768
BBBmau merged 1 commit into
GoogleCloudPlatform:mainfrom
BBBmau:storage-identity-update

Conversation

@BBBmau

@BBBmau BBBmau commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Fixes hashicorp/terraform-provider-google#27595
Fixes hashicorp/terraform-provider-google#27596

This slipped through due to the missing identity error only existing in older versions of terraform.

In an attempt to reproduce i got no error on terraform version 1.14.0

however when downgrading to 1.5.7 i get the following:

󰀵 mau  …/󰲋 /Scratch/storage_bucket_identity_bug   12:30   envchain GCLOUD terraform apply
google_storage_bucket.bucket: Refreshing state... [id=storage-identity-bucket]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # google_storage_bucket.bucket will be updated in-place
  ~ resource "google_storage_bucket" "bucket" {
      ~ force_destroy               = true -> false
        id                          = "storage-identity-bucket"
        name                        = "storage-identity-bucket"
        # (17 unchanged attributes hidden)

        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

google_storage_bucket.bucket: Modifying... [id=storage-identity-bucket]

│ Error: Missing Resource Identity After Update: The Terraform provider unexpectedly returned no resource identity after having no errors in the resource update. This is always a problem with the provider and should be reported to the provider developer

│   with google_storage_bucket.bucket,
│   on main.tf line 1, in resource "google_storage_bucket" "bucket":
│    1: resource "google_storage_bucket" "bucket" {


Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storage: fixed missing identity error when updating values in `google_storage_bucket`

@modular-magician

modular-magician commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7a2f23d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 4 insertions(+), 1 deletion(-)
google-beta provider View Diff 1 file changed, 4 insertions(+), 1 deletion(-)

Test report

Analytics

Total Tests Passed Skipped Affected
135 124 11 0
Affected Service Packages
  • storage

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@BBBmau VCR tests complete for 7a2f23d!

@BBBmau BBBmau requested review from zli82016 and removed request for sameer-google May 29, 2026 19:26
@zli82016

Copy link
Copy Markdown
Member

Need to wait for tests run complete before merging the PR.

@BBBmau BBBmau added this pull request to the merge queue May 29, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 81f3835 May 29, 2026
27 of 28 checks passed
@BBBmau BBBmau deleted the storage-identity-update branch May 29, 2026 21:24
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment