fix: testing-isolation trim spaces on diffs (#3933)

David Cavazos · code-review-assist[bot] · web-flow · commit 5a95a5356c07 · 2024-12-12T12:20:36.000-08:00
* fix: testing-isolation trim spaces on diffs

* Update .github/cloud-samples-tools/cmd/main.go

Co-authored-by: code-review-assist[bot] &lt;182814678+code-review-assist[bot]@users.noreply.github.com&gt;

* fix indent

---------

Co-authored-by: code-review-assist[bot] &lt;182814678+code-review-assist[bot]@users.noreply.github.com&gt;
diff --git a/.github/cloud-samples-tools/cmd/main.go b/.github/cloud-samples-tools/cmd/main.go
@@ -72,7 +72,7 @@ func affectedCmd(configFile string, diffsFile string) {
 	if err != nil {
 		log.Fatalln("❌ error getting the diffs: ", diffsFile, "\n", err)
 	}
-	diffs := strings.Split(string(diffsBytes), "\n")
+	diffs := strings.Split(strings.TrimSpace(string(diffsBytes)), "\n") // Trim whitespace to remove extra newline from diff output.
 
 	packages, err := config.Affected(diffs)
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ func affectedCmd(configFile string, diffsFile string) {`
`72`	`72`	`if err != nil {`
`73`	`73`	`log.Fatalln("❌ error getting the diffs: ", diffsFile, "\n", err)`
`74`	`74`	`}`
`75`		`- diffs := strings.Split(string(diffsBytes), "\n")`
	`75`	`+ diffs := strings.Split(strings.TrimSpace(string(diffsBytes)), "\n") // Trim whitespace to remove extra newline from diff output.`
`76`	`76`
`77`	`77`	`packages, err := config.Affected(diffs)`
`78`	`78`	`if err != nil {`