Skip to content

Commit eb7d8a8

Browse files
committed
feat(secretmanager): updating as per comment
1 parent 400dd49 commit eb7d8a8

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

secret-manager/createSecretWithExpiration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ async function main(parent, secretId) {
5454
}
5555

5656
createSecretWithExpiration();
57+
// [END secretmanager_create_secret_with_expiration]
5758
}
58-
// [END secretmanager_create_secret_with_expiration]
5959

6060
const args = process.argv.slice(2);
6161
main(...args).catch(console.error);

secret-manager/createSecretWithUserManagedReplicationPolicy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ async function main(parent, secretId, locations, ttl) {
2222
// const parent = 'projects/my-project';
2323
// const secretId = 'my-new-secret';
2424
// const locations = ['us-east1', 'europe-west1'];
25-
// const ttl = '7776000s'; // Optional: 90 days in seconds
25+
// const ttl = 7776000; // Optional: 90 days in seconds
2626

2727
// Import the Secret Manager library
2828
const {SecretManagerServiceClient} = require('@google-cloud/secret-manager');

secret-manager/regional_samples/createRegionalSecretWithExpiration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ async function main(projectId, locationId, secretId) {
5757
}
5858

5959
createRegionalSecretWithExpiration();
60+
// [END secretmanager_create_regional_secret_with_expire_time]
6061
}
61-
// [END secretmanager_create_regional_secret_with_expire_time]
6262

6363
const args = process.argv.slice(2);
6464
main(...args).catch(console.error);

secret-manager/test/secretmanager.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1028,7 +1028,7 @@ describe('Secret Manager samples', () => {
10281028
it('create secret with user managed replication policy', async () => {
10291029
const parent = `projects/${projectId}`;
10301030
const locations = ['us-east1', 'us-east5'];
1031-
const ttl = '900s';
1031+
const ttl = 900;
10321032
const output = execSync(
10331033
`node createSecretWithUserManagedReplicationPolicy.js ${parent} ${secretId}-ummr ${locations} ${ttl}`
10341034
);

0 commit comments

Comments
 (0)