fix(parametermanager): Fixed test cases

GoogleCloudPlatform · Feb 26, 2025 · ece26d6 · ece26d6
1 parent 9bcebd3
commit ece26d6
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 13 deletions.
diff --git a/parameter-manager/listParamVersions.js b/parameter-manager/listParamVersions.js
@@ -47,7 +47,6 @@ async function main(projectId = 'my-project', parameterId = 'my-parameter') {
     // Use listParameterVersionsAsync to handle pagination automatically
     const iterable = await client.listParameterVersionsAsync(request);
 
-    console.log(`Parameter versions for ${parameterId}:`);
     for await (const version of iterable) {
       console.log(
         `Found parameter version ${version.name} with state ${version.disabled ? 'disabled' : 'enabled'}`

diff --git a/parameter-manager/listParams.js b/parameter-manager/listParams.js
@@ -44,7 +44,6 @@ async function main(projectId = 'my-project') {
     // Use listParametersAsync to handle pagination automatically
     const iterable = await client.listParametersAsync(request);
 
-    console.log('Parameters:');
     for await (const parameter of iterable) {
       console.log(
         `Found parameter ${parameter.name} with format ${parameter.format}`

diff --git a/parameter-manager/regional_samples/listRegionalParamVersions.js b/parameter-manager/regional_samples/listRegionalParamVersions.js
@@ -57,7 +57,6 @@ async function main(
     // Use listParameterVersionsAsync to handle pagination automatically
     const iterable = await client.listParameterVersionsAsync(request);
 
-    console.log(`Parameter versions for ${parameterId} in ${locationId}:`);
     for await (const version of iterable) {
       console.log(
         `Found regional parameter version ${version.name} with state ${version.disabled ? 'disabled' : 'enabled'} `

diff --git a/parameter-manager/regional_samples/listRegionalParams.js b/parameter-manager/regional_samples/listRegionalParams.js
@@ -51,7 +51,6 @@ async function main(projectId = 'my-project', locationId = 'us-central1') {
     // Use listParametersAsync to handle pagination automatically
     const iterable = await client.listParametersAsync(request);
 
-    console.log(`Parameters in ${locationId}:`);
     for await (const parameter of iterable) {
       console.log(
         `Found regional parameter ${parameter.name} with format ${parameter.format}`

diff --git a/parameter-manager/test/parametermanager.test.js b/parameter-manager/test/parametermanager.test.js
@@ -305,7 +305,6 @@ describe('Parameter Manager samples', () => {
 
   it('should list parameters', async () => {
     const output = execSync(`node listParams.js ${projectId}`);
-    assert.include(output, 'Parameters:');
     assert.include(
       output,
       `Found parameter ${parameter.name} with format ${parameter.format}`
@@ -324,7 +323,6 @@ describe('Parameter Manager samples', () => {
     const output = execSync(
       `node regional_samples/listRegionalParams.js ${projectId} ${locationId}`
     );
-    assert.include(output, `Parameters in ${locationId}:`);
     assert.include(
       output,
       `Found regional parameter ${regionalParameter.name} with format ${regionalParameter.format}`
@@ -381,7 +379,6 @@ describe('Parameter Manager samples', () => {
     const output = execSync(
       `node listParamVersions.js ${projectId} ${parameterId}`
     );
-    assert.include(output, `Parameter versions for ${parameterId}:`);
     assert.include(
       output,
       `Found parameter version ${parameterVersion.name} with state disabled`
@@ -396,10 +393,6 @@ describe('Parameter Manager samples', () => {
     const output = execSync(
       `node regional_samples/listRegionalParamVersions.js ${projectId} ${locationId} ${regionalParameterId}`
     );
-    assert.include(
-      output,
-      `Parameter versions for ${regionalParameterId} in ${locationId}:`
-    );
     assert.include(
       output,
       `Found regional parameter version ${regionalParameterVersion.name} with state disabled`
@@ -428,7 +421,7 @@ describe('Parameter Manager samples', () => {
     );
     assert.include(
       output,
-      'Payload: {"db_user":"test_user","db_password":"__REF__(//secretmanager.googleapis.com/projects/385768059301/secrets/test-secret-91cd9792-5f13-47c5-85ba-6622682f0035/versions/1)"}'
+      `Payload: {"db_user":"test_user","db_password":"__REF__(//secretmanager.googleapis.com/${secretVersion.name})"}`
     );
   });
 
@@ -450,7 +443,7 @@ describe('Parameter Manager samples', () => {
     );
     assert.include(
       output,
-      'Payload: {"db_user":"test_user","db_password":"__REF__("//secretmanager.googleapis.com/projects/385768059301/locations/us-central1/secrets/test-secret-91cd9792-5f13-47c5-85ba-6622682f0035/versions/1")"}'
+      `Payload: {"db_user":"test_user","db_password":"__REF__(\\"//secretmanager.googleapis.com/${regionalSecretVersion.name}\\")"}`
     );
   });