Skip to content

Commit df653dc

Browse files
authored
Fix slow test (#319)
1 parent ea4cddc commit df653dc

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

exporter/collector/googlecloud_test.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package collector
1717
import (
1818
"context"
1919
"net"
20+
"sync"
2021
"testing"
2122
"time"
2223

@@ -181,8 +182,12 @@ func TestGoogleCloudMetricExport(t *testing.T) {
181182
}
182183

183184
sde, err := NewGoogleCloudMetricsExporter(context.Background(), config, zap.NewNop(), "v0.0.1", DefaultTimeout)
185+
shutdownOnce := sync.Once{}
186+
shutdown := func() {
187+
require.NoError(t, sde.Shutdown(context.Background()))
188+
}
184189
require.NoError(t, err)
185-
defer func() { require.NoError(t, sde.Shutdown(context.Background())) }()
190+
defer shutdownOnce.Do(shutdown)
186191

187192
md := agentmetricspb.ExportMetricsServiceRequest{
188193
Resource: &resourcepb.Resource{
@@ -243,6 +248,7 @@ func TestGoogleCloudMetricExport(t *testing.T) {
243248
md.Metrics[4].Resource = &resourcepb.Resource{}
244249

245250
assert.NoError(t, sde.PushMetrics(context.Background(), internaldata.OCToMetrics(md.Node, md.Resource, md.Metrics)), err)
251+
shutdownOnce.Do(shutdown)
246252

247253
expectedNames := map[string]struct{}{
248254
"workload.googleapis.com/test_gauge1": {},

0 commit comments

Comments
 (0)