Skip to content

Commit 2b4c206

Browse files
authored
Merge pull request #1190 from douglasjacobsen/variants-in-results
Include variant definitions in results
2 parents 0a77b75 + da0d26d commit 2b4c206

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

lib/ramble/ramble/experiment_result.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ class ExperimentStatus(str, Enum):
3535
namespace.variables: "RAMBLE_VARIABLES",
3636
"raw_variables": "RAMBLE_RAW_VARIABLES",
3737
namespace.tags: "TAGS",
38+
namespace.variants: "VARIANTS",
3839
"experiment_chain": "EXPERIMENT_CHAIN",
3940
"success_criteria": "SUCCESS_CRITERIA",
4041
}
@@ -72,6 +73,13 @@ def __init__(self, app_inst):
7273
if var not in app_inst.keywords.keys or not app_inst.keywords.is_key_level(var):
7374
self.variables[var] = app_inst.expander.expand_var(val)
7475

76+
self.variants = set()
77+
for _, obj_inst in app_inst._objects():
78+
if hasattr(obj_inst, "object_variants"):
79+
obj_var_set = obj_inst.object_variants.as_set()
80+
self.variants = self.variants.union(obj_var_set)
81+
self.variants = list(self.variants)
82+
7583
def to_dict(self):
7684
"""Generate a dict for encoders (json, yaml) and uploaders.
7785

lib/ramble/ramble/workspace/workspace.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1744,6 +1744,11 @@ def dump_results(self, output_formats=None, print_results=False, summary_only=Fa
17441744
if software_key in exp and exp[software_key]:
17451745
self.write_software_info(f, exp)
17461746

1747+
if exp["VARIANTS"]:
1748+
f.write(" Experiment variants:\n")
1749+
for variant in exp["VARIANTS"]:
1750+
f.write(f" - {variant}\n")
1751+
17471752
if exp["SUCCESS_CRITERIA"]:
17481753
f.write(" Success criteria summary:\n")
17491754
for name, result in exp["SUCCESS_CRITERIA"].items():

0 commit comments

Comments
 (0)