Prune the now redundant upper and lower string methods

Author: linsword13

lib/ramble/docs/workspace_config.rst

@@ -184,8 +184,6 @@ Supported functions are:
 * ``randint`` (from `random.randint`)
 * ``join_str(iterable, sep=",")`` (concatenate iterable into ``sep``-separated string)
 * ``re_search(regex, str)`` (determine if ``str`` contains pattern ``regex``, based on ``re.search``)
-* ``upper_str(str)`` (convert ``str`` to uppercase)
-* ``lower_str(str)`` (convert ``str`` to lowercase)
 * ``maybe(var_name, default="")`` (returns the expanded ``var_name`` if it is defined, otherwise returns ``default``)
 
 Besides the above listed, any functions from the ``math`` module can be used in Ramble by referencing ``math_<function_name>``.
@@ -196,7 +194,7 @@ String slicing is supported:
 * ``str[start:end:step]`` (string slicing)
 
 In addition to the listed, any string methods can be used by referencing ``str_<method_name>``.
-For example, ``str_capitalize(<str>)`` invokes the ``<str>.capitalize()`` method.
+For example, ``str_upper(<str>)`` invokes the ``<str>.upper()`` method.
 
 Dictionary references are supported:
 

lib/ramble/ramble/expander.py

@@ -38,14 +38,6 @@ def _join_str(seq, sep=","):
     return sep.join(str(i) for i in seq)
 
 
-def _upper_str(in_str):
-    return in_str.upper()
-
-
-def _lower_str(in_str):
-    return in_str.lower()
-
-
 def _re_search(regex, s):
     return re.search(regex, s) is not None
 
@@ -128,8 +120,6 @@ def _maybe(expander, var_name, default=""):
     "simplify_str": spack.util.naming.simplify_name,
     "join_str": _join_str,
     "re_search": _re_search,
-    "upper_str": _upper_str,
-    "lower_str": _lower_str,
 }
 
 # Format Spec Regex:

lib/ramble/ramble/test/expander.py

@@ -146,8 +146,8 @@ def build_variant_set():
         ("math_sqrt(64)", "8.0", set(), 1),
         ("math_log(9, 3)", "2.0", set(), 1),
         ("math_not_exist(1)", "math_not_exist(1)", set(), 1),
-        ("upper_str('foo')", "FOO", set(), 1),
-        ("lower_str('FOO')", "foo", set(), 1),
+        ("str_upper('foo')", "FOO", set(), 1),
+        ("str_lower('FOO')", "foo", set(), 1),
         ("str_capitalize('foo')", "Foo", set(), 1),
         ("str_lstrip('AAAbbb', 'A')", "bbb", set(), 1),
         ("str_join('.', str_split('a b c 1'))", "a.b.c.1", set(), 1),