Skip to content

Commit c45920c

Browse files
Fix issues with expanding variant values
1 parent b3837e7 commit c45920c

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

lib/ramble/ramble/expander.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -756,10 +756,12 @@ def satisfies(
756756
the input requirement.
757757
"""
758758

759-
if variant_set is not None:
760-
variant_definitions = variant_set.as_set()
761-
else:
762-
variant_definitions = set()
759+
variant_definitions = set()
760+
761+
if hasattr(variant_set, "as_set"):
762+
for variant in variant_set.as_set():
763+
exp_variant = self.expand_var(variant)
764+
variant_definitions.add(exp_variant)
763765

764766
satisfied = True
765767
if reqs is not None:

var/ramble/repos/builtin/base_classes/application-base/base_class.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,8 @@ def set_variables_and_variants(self, variables, variants, experiment_set):
598598
for cls in base_chain:
599599
if hasattr(cls, "name") and cls.name is not None:
600600
self.object_variants.multi_value_variant(
601-
"application_name", value=cls.name
601+
"application_name",
602+
value=self.expander.application_name,
602603
)
603604

604605
# Define workload_name variant as early as possible

0 commit comments

Comments
 (0)