Merge pull request #73 from nirupama-dev/bug-sonar-run

fixed issues in list, create notebook scheduler and execution history expand button

Author: risha-vijayvargiya-22

src/scheduler/NotebookScheduler.tsx

@@ -59,8 +59,7 @@ const NotebookSchedulerComponent = ({
     useState<boolean>(false);
   const [jobNameUniqueValidation, setJobNameUniqueValidation] =
     useState<boolean>(true);
-  const [createCompleted, setCreateCompleted] =
-    context !== '' ? useState(false) : useState(true);
+  const [createCompleted, setCreateCompleted] = useState(context !== '' ? false : true);
   const [notebookSelector, setNotebookSelector] = useState<string>('vertex');
   const [executionPageFlag, setExecutionPageFlag] = useState<boolean>(true);
   const [isApiError, setIsApiError] = useState(false);

src/scheduler/composer/CreateNotebookScheduler.tsx

@@ -205,7 +205,7 @@ const CreateNotebookScheduler = ({
       const selectedComposer = data.toString();
       setComposerSelected(selectedComposer);
       if (selectedComposer) {
-        const unique = getDaglist(selectedComposer);
+        const unique = await getDaglist(selectedComposer);
         if (!unique) {
           setJobNameUniqueValidation(true);
         }

src/scheduler/composer/ListDagTaskInstances.tsx

@@ -181,6 +181,7 @@ const ListDagTaskInstances = ({
                   {taskInstance.tryNumber !== 0 ? (
                     <div
                       className="accordion-row-data-expand-logo"
+                      role="button"
                       onClick={() =>
                         handleChange(
                           index,

src/scheduler/composer/ListNotebookScheduler.tsx

@@ -75,7 +75,7 @@ interface IDagList {
   scheduleInterval: string;
 }
 
-function listNotebookScheduler({
+function ListNotebookScheduler({
   app,
   settingRegistry,
   handleDagIdSelection,
@@ -155,22 +155,22 @@ function listNotebookScheduler({
   composerSelected?: string;
   setApiEnableUrl: any;
 }) {
-  const [isLoading, setIsLoading] = useState(true);
+  const [isLoading, setIsLoading] = useState<boolean>(true);
   const [composerList, setComposerList] = useState<string[]>([]);
   const [composerSelectedList, setComposerSelectedList] = useState<string>('');
   const [dagList, setDagList] = useState<IDagList[]>([]);
   const data = dagList;
   const backselectedEnvironment = backButtonComposerName;
-  const [deletePopupOpen, setDeletePopupOpen] = useState(false);
-  const [importErrorPopupOpen, setImportErrorPopupOpen] = useState(false);
+  const [deletePopupOpen, setDeletePopupOpen] = useState<boolean>(false);
+  const [importErrorPopupOpen, setImportErrorPopupOpen] = useState<boolean>(false);
   const [selectedDagId, setSelectedDagId] = useState('');
   const [editDagLoading, setEditDagLoading] = useState('');
   const [inputNotebookFilePath, setInputNotebookFilePath] = useState('');
   const [editNotebookLoading, setEditNotebookLoading] = useState('');
-  const [deletingNotebook, setDeletingNotebook] = useState(false);
+  const [deletingNotebook, setDeletingNotebook] = useState<boolean>(false);
   const [importErrorData, setImportErrorData] = useState<string[]>([]);
   const [importErrorEntries, setImportErrorEntries] = useState<number>(0);
-  const [isGCSPluginInstalled, setIsGCSPluginInstalled] = useState(false);
+  const [isGCSPluginInstalled, setIsGCSPluginInstalled] = useState<boolean>(false);
   const [projectId, setProjectId] = useState('');
   const [region, setRegion] = useState<string>('');
   const [loaderProjectId, setLoaderProjectId] = useState<boolean>(false);
@@ -840,4 +840,4 @@ function listNotebookScheduler({
     </div>
   );
 }
-export default listNotebookScheduler;
+export default ListNotebookScheduler;