Skip to content

Commit de71cfe

Browse files
Merge pull request #76 from nirupama-dev/bug-vertex-delete
Fixed issue with blank screen after deleting a schedule in vertex and syntax issue in dag template files for composer
2 parents c8414bc + 4d49981 commit de71cfe

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

scheduler_jupyter_plugin/dagTemplates/localPythonTemplate-v1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ default_args = {
2424
'start_date': '{{start_date}}',
2525
'retries': '{{retry_count}}',
2626
'retry_delay': timedelta(minutes=int('{{retry_delay}}')),
27-
'email': {{email}},
27+
'email': {{email | safe}}, # Should be a list, e.g., ['user@example.com']
2828
'email_on_failure': {{email_failure}},
2929
'email_on_retry': {{email_delay}},
3030
'email_on_success': {{email_success}}

scheduler_jupyter_plugin/dagTemplates/pysparkBatchTemplate-v1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ default_args = {
2626
'start_date': '{{start_date}}',
2727
'retries': '{{retry_count}}',
2828
'retry_delay': timedelta(minutes=int('{{retry_delay}}')),
29-
'email': {{email}},
29+
'email': {{email | safe}}, # Should be a list, e.g., ['user@example.com']
3030
'email_on_failure': {{email_failure}},
3131
'email_on_retry': {{email_delay}},
3232
'email_on_success': {{email_success}}

scheduler_jupyter_plugin/dagTemplates/pysparkJobTemplate-v1.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ default_args = {
2424
'start_date': '{{start_date}}',
2525
'retries': '{{retry_count}}',
2626
'retry_delay': timedelta(minutes=int('{{retry_delay}}')),
27-
'email': {{email}},
27+
'email': {{email | safe}}, # Should be a list, e.g., ['user@example.com']
2828
'email_on_failure': {{email_failure}},
2929
'email_on_retry': {{email_delay}},
3030
'email_on_success': {{email_success}}

src/scheduler/common/EnableNotifyMessage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ const EnableNotifyMessage = ({
2424
message: string;
2525
url: any;
2626
}): JSX.Element => {
27-
const beforeLink = message.split('. ')[0] || '';
27+
const beforeLink = message?.split('. ')[0] || '';
2828
return (
2929
<>
3030
{beforeLink}
3131
<a
32-
href={url[0]}
32+
href={url?.[0]}
3333
target="_blank"
3434
rel="noopener noreferrer"
3535
className="cursor-icon"

src/services/Vertex.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -926,7 +926,7 @@ export class VertexServices {
926926
) => {
927927
// Controller to abort pending API call
928928
const controller = new AbortController();
929-
abortControllers.current.push(controller);
929+
abortControllers?.current.push(controller);
930930
const signal = controller.signal;
931931

932932
//Extract Schedule id from schedule name.

0 commit comments

Comments
 (0)