Skip to content

Commit 2379d73

Browse files
Cleanup deprecated fhir store notification_config (#1192)
* run ./scripts/regen.sh for unit test failure * test for genrated file check * test for genrated file check * Revert "run ./scripts/regen.sh for unit test failure" This reverts commit 6d64e0a. * updated genertaed file (not using ./scripts/regen.sh) * remove gen_check modification * regenerate docs * cleanup deprecated fhir store notification_config --------- Co-authored-by: yeweidaniel <[email protected]>
1 parent f7b5327 commit 2379d73

File tree

5 files changed

+2
-19
lines changed

5 files changed

+2
-19
lines changed

docs/tfengine/schemas/resources.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@
159159
| healthcare_datasets.fhir_stores.labels | Labels to set on the FHIR store. | object | false | - | - |
160160
| healthcare_datasets.fhir_stores.labels.*pattern* | - | string | false | - | .+ |
161161
| healthcare_datasets.fhir_stores.name | Name of FHIR store. | string | true | - | - |
162-
| healthcare_datasets.fhir_stores.notification_config | See <https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/healthcare_fhir_store#notification_config>. | object | false | - | - |
163162
| healthcare_datasets.fhir_stores.notification_configs | See <https://registry.terraform.io/providers/hashicorp/google-beta/latest/docs/resources/healthcare_fhir_store#notification_configs>. | array(object) | false | - | - |
164163
| healthcare_datasets.fhir_stores.notification_configs.pubsub_topic | - | string | true | - | - |
165164
| healthcare_datasets.fhir_stores.notification_configs.send_full_resource | - | boolean | false | - | - |

examples/tfengine/generated/team/project_data/main.tf

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,6 @@ module "healthcare_dataset" {
155155
disable_referential_integrity = false
156156
disable_resource_versioning = false
157157
enable_history_import = false
158-
notification_config = {
159-
pubsub_topic = "projects/example-prod-data/topics/${module.topic.topic}"
160-
}
161158
notification_configs = [
162159
{
163160
pubsub_topic = "projects/example-prod-data/topics/${module.topic.topic}"

examples/tfengine/modules/team.hcl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -418,10 +418,7 @@ template "project_data" {
418418
labels = {
419419
type = "phi"
420420
}
421-
notification_config = {
422-
pubsub_topic = "projects/{{.prefix}}-{{.env}}-data/topics/$${module.topic.topic}"
423-
}
424-
notification_configs = [{
421+
notification_configs = [{
425422
pubsub_topic = "projects/{{.prefix}}-{{.env}}-data/topics/$${module.topic.topic}"
426423
send_full_resource = true
427424
send_previous_resource_on_delete = true

templates/tfengine/components/resources/healthcare_datasets/main.tf

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,6 @@ module "{{resourceName . "name"}}" {
8181

8282
{{hclField . "iam_members" -}}
8383

84-
{{if has . "notification_config" -}}
85-
notification_config = {
86-
{{hcl .notification_config}}
87-
}
88-
{{end -}}
89-
9084
{{if has . "notification_configs" -}}
9185
notification_configs = [
9286
{{range $k, $v := .notification_configs -}}

templates/tfengine/recipes/resources.hcl

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -990,11 +990,7 @@ schema = {
990990
}
991991
}
992992
}
993-
notification_config = {
994-
description = "See <https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/healthcare_fhir_store#notification_config>."
995-
type = "object"
996-
}
997-
notification_configs = {
993+
notification_configs = {
998994
description = "See <https://registry.terraform.io/providers/hashicorp/google-beta/latest/docs/resources/healthcare_fhir_store#notification_configs>."
999995
type = "array"
1000996
items = {

0 commit comments

Comments
 (0)