Skip to content

Commit 82134de

Browse files
fix rds bug (#1736)
1 parent cbea4de commit 82134de

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

providers/aws/rds.go

+15-2
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,15 @@ func (g *RDSGenerator) loadDBInstances(svc *rds.Client) error {
101101
}
102102
for _, db := range page.DBInstances {
103103
resourceName := StringValue(db.DBInstanceIdentifier)
104-
g.Resources = append(g.Resources, terraformutils.NewSimpleResource(
104+
r := terraformutils.NewSimpleResource(
105105
resourceName,
106106
resourceName,
107107
"aws_db_instance",
108108
"aws",
109109
RDSAllowEmptyValues,
110-
))
110+
)
111+
r.IgnoreKeys = append(r.IgnoreKeys, "^name$")
112+
g.Resources = append(g.Resources, r)
111113
}
112114
}
113115
return nil
@@ -295,6 +297,17 @@ func (g *RDSGenerator) InitResources() error {
295297
func (g *RDSGenerator) PostConvertHook() error {
296298
for i, r := range g.Resources {
297299
if r.InstanceInfo.Type == "aws_db_instance" || r.InstanceInfo.Type == "aws_rds_cluster" {
300+
for _, dbInstance := range g.Resources {
301+
if dbInstance.InstanceInfo.Type != "aws_db_instance" {
302+
continue
303+
}
304+
if g.Resources[i].Item["replicate_source_db"] != nil {
305+
delete(g.Resources[i].Item, "username")
306+
delete(g.Resources[i].Item, "engine_version")
307+
delete(g.Resources[i].Item, "engine")
308+
delete(g.Resources[i].Item, "db_name")
309+
}
310+
}
298311

299312
for _, parameterGroup := range g.Resources {
300313
if parameterGroup.InstanceInfo.Type != "aws_db_parameter_group" {

0 commit comments

Comments
 (0)