Skip to content

Commit ff92ebe

Browse files
Merge pull request #86 from gurusai-voleti/br_4315
removed model_garden folder changes
2 parents ccdb33e + c1378af commit ff92ebe

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

notebooks/community/model_garden/model_garden_openai_api_llama3_1.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@
253253
},
254254
"outputs": [],
255255
"source": [
256-
"! gcloud storage buckets create --location={LOCATION} --project={PROJECT_ID} {BUCKET_URI}"
256+
"! gsutil mb -l {LOCATION} -p {PROJECT_ID} {BUCKET_URI}"
257257
]
258258
},
259259
{
@@ -1237,7 +1237,7 @@
12371237
" rag.delete_corpus(name=rag_corpus.name)\n",
12381238
"\n",
12391239
"if delete_bucket:\n",
1240-
" ! gcloud storage rm --recursive $BUCKET_NAME"
1240+
" ! gsutil -m rm -r $BUCKET_NAME"
12411241
]
12421242
}
12431243
],

notebooks/community/model_garden/model_garden_pytorch_mixtral_deployment.ipynb

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -174,10 +174,10 @@
174174
"if BUCKET_URI is None or BUCKET_URI.strip() == \"\" or BUCKET_URI == \"gs://\":\n",
175175
" BUCKET_URI = f\"gs://{PROJECT_ID}-tmp-{now}-{str(uuid.uuid4())[:4]}\"\n",
176176
" BUCKET_NAME = \"/\".join(BUCKET_URI.split(\"/\")[:3])\n",
177-
" ! gcloud storage buckets create --location {REGION} {BUCKET_URI}\n",
177+
" ! gsutil mb -l {REGION} {BUCKET_URI}\n",
178178
"else:\n",
179179
" assert BUCKET_URI.startswith(\"gs://\"), \"BUCKET_URI must start with `gs://`.\"\n",
180-
" shell_output = ! gcloud storage ls --full --buckets {BUCKET_NAME} | grep \"Location Constraint:\" | sed \"s/Location Constraint://\"\n",
180+
" shell_output = ! gsutil ls -Lb {BUCKET_NAME} | grep \"Location constraint:\" | sed \"s/Location constraint://\"\n",
181181
" bucket_region = shell_output[0].strip().lower()\n",
182182
" if bucket_region != REGION:\n",
183183
" raise ValueError(\n",
@@ -202,7 +202,7 @@
202202
"\n",
203203
"\n",
204204
"# Provision permissions to the SERVICE_ACCOUNT with the GCS bucket\n",
205-
"! gcloud storage buckets add-iam-policy-binding $BUCKET_NAME --member=serviceAccount:{SERVICE_ACCOUNT} --role=roles/storage.admin\n",
205+
"! gsutil iam ch serviceAccount:{SERVICE_ACCOUNT}:roles/storage.admin $BUCKET_NAME\n",
206206
"\n",
207207
"! gcloud config set project $PROJECT_ID\n",
208208
"! gcloud projects add-iam-policy-binding --no-user-output-enabled {PROJECT_ID} --member=serviceAccount:{SERVICE_ACCOUNT} --role=\"roles/storage.admin\"\n",
@@ -236,9 +236,7 @@
236236
"# https://cloud.google.com/vertex-ai/docs/predictions/configure-compute.\n",
237237
"\n",
238238
"# @markdown L4 GPUs are good serving solutions and are more cost effective than V100s for 8x7B models. The 8x22B models only works with A100/H100 GPUs now.\n",
239-
"accelerator_type = (\n",
240-
" \"NVIDIA_L4\" # @param [\"NVIDIA_L4\", \"NVIDIA_TESLA_V100\", \"NVIDIA_H100_80GB\"]\n",
241-
")\n",
239+
"accelerator_type = \"NVIDIA_L4\" # @param [\"NVIDIA_L4\", \"NVIDIA_TESLA_V100\", \"NVIDIA_H100_80GB\"]\n",
242240
"\n",
243241
"if accelerator_type == \"NVIDIA_L4\":\n",
244242
" machine_type = \"g2-standard-96\"\n",
@@ -828,7 +826,7 @@
828826
"\n",
829827
"delete_bucket = False # @param {type:\"boolean\"}\n",
830828
"if delete_bucket:\n",
831-
" ! gcloud storage rm --recursive $BUCKET_NAME"
829+
" ! gsutil -m rm -r $BUCKET_NAME"
832830
]
833831
}
834832
],

0 commit comments

Comments
 (0)