cleanup: refactor some unit tests to use exact errors #1569
Conversation
Camila-B
commented
Feb 25, 2025
Camila-B
commented
- Removes reference to obsolete bug
- Cleans some tests up by validating errors by their exact type and message and not just their error code
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
| @@ -350,7 +350,6 @@ func gitSyncEnvs(_ context.Context, opts options) []corev1.EnvVar { | |||
| }) | |||
| } | |||
| default: | |||
| // TODO b/168553377 Return error while setting up gitSyncData. | |||
There was a problem hiding this comment.
Looks like this "feature request" would have been a relatively minor chore PR to fix, to return the error through a few layers of functions. Can you just expose the error instead in a separate PR from the other changes here?
upsertManagedObjects already returns an error, so you probably only have to modify populateContainerEnvs & gitSyncEnvs.
There was a problem hiding this comment.
Sure, I'll do that in a separate PR. For now, I re-added the comment back.
- Cleans some tests up by validating errors by the exact type and message and not just the error code
Camila-B
changed the title
