webview test

Author: monkeyWie

.github/workflows/test.yml

@@ -53,54 +53,73 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
+      - name: Install webview dependencies
+        run: |
+          sudo apt-get update -y
+          sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.0-dev xvfb
       - name: Run Unit tests.
         run: |
           # Get packages for testing and coverage (including cmd/web for flags_test.go)
-          PACKAGES=$(go list ./... | grep -v /bind/ | grep -v -E '/cmd/(?!web)')
-          go test -v -coverpkg=$(echo "$PACKAGES" | paste -sd "," -) -covermode=count -coverprofile=coverage.txt $PACKAGES
+          PACKAGES=$(go list ./... | awk '!/\/bind\// && (!/\/cmd\// || /\/cmd\/web$/)')
+          env CGO_ENABLED=1 xvfb-run -a go test -tags webview -v -coverpkg=$(echo "$PACKAGES" | paste -sd "," -) -covermode=count -coverprofile=coverage.txt $PACKAGES
           # Filter out main.go from coverage report to avoid lowering coverage percentage
           grep -v "main.go" coverage.txt > coverage_filtered.txt || true
           mv coverage_filtered.txt coverage.txt
       - uses: codecov/codecov-action@v4
         with:
           files: ./coverage.txt
           token: ${{ secrets.CODECOV_UPLOAD_TOKEN }}
-  test-webview:
-    name: Test webview (${{ matrix.os }})
+  test-webview-integration:
+    name: Test webview integration (${{ matrix.name }})
     strategy:
       fail-fast: false
       matrix:
-        os: [ ubuntu-22.04, macos-latest, windows-latest ]
+        include:
+          - name: Windows
+            os: windows-latest
+          - name: macOS
+            os: macos-latest
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v5
         with:
           go-version: ${{ env.GO_VERSION }}
-      - name: Install webview dependencies (Linux)
-        if: runner.os == 'Linux'
-        run: |
-          sudo apt-get update -y
-          sudo apt-get install -y libgtk-3-dev libwebkit2gtk-4.0-dev xvfb
-      - name: Build check (CGO enabled)
-        run: CGO_ENABLED=1 go build -tags webview ./internal/webview/goprovider/
-        shell: bash
-      - name: Go vet
-        run: CGO_ENABLED=1 go vet -tags webview ./internal/webview/goprovider/
-        shell: bash
-      - name: Test webview (Linux)
-        if: runner.os == 'Linux'
-        run: xvfb-run CGO_ENABLED=1 go test -tags webview -v -timeout 120s
-          ./internal/webview/goprovider/
-      - name: Test webview (macOS)
+      - uses: subosito/flutter-action@v2
         if: runner.os == 'macOS'
-        run: CGO_ENABLED=1 go test -tags webview -v -timeout 120s
-          ./internal/webview/goprovider/
-      - name: Test webview (Windows)
+        with:
+          flutter-version: ${{ env.FLUTTER_VERSION }}
+      - name: Test webview
         if: runner.os == 'Windows'
-        run: go test -tags webview -v -timeout 120s ./internal/webview/goprovider/
+        run: go test -tags webview -v -timeout 300s ./internal/webview/goprovider/
         env:
           CGO_ENABLED: 1
+      - name: Test webview
+        if: runner.os == 'macOS'
+        shell: bash
+        run: |
+          set -euo pipefail
+          SOCKET_PATH="$HOME/Library/Application Support/com.gopeed.gopeed/gopeed_webview.sock"
+          LOG_PATH="$RUNNER_TEMP/gopeed-webview-rpc.log"
+          rm -f "$SOCKET_PATH"
+
+          go build -tags nosqlite -ldflags="-w -s" -buildmode=c-shared -o ui/flutter/macos/Frameworks/libgopeed.dylib github.com/GopeedLab/gopeed/bind/desktop
+
+          cd ui/flutter
+          flutter pub get
+          flutter run -d macos >"$LOG_PATH" 2>&1 &
+          FLUTTER_PID=$!
+          cd ../..
+
+          cleanup() {
+            kill "$FLUTTER_PID" >/dev/null 2>&1 || true
+          }
+          trap cleanup EXIT
+
+          if ! go test -tags webview -v -timeout 600s ./internal/webview/rpcprovider/ -args -webview-rpc-network unix -webview-rpc-address "$SOCKET_PATH"; then
+            cat "$LOG_PATH"
+            exit 1
+          fi
 
   build-desktop:
     strategy:

bind/desktop/webview_provider_darwin_test.go

@@ -1,4 +1,4 @@
-//go:build cgo && webview
+//go:build cgo
 
 package goprovider
 

bind/desktop/webview_provider_other_test.go

@@ -0,0 +1,15 @@
+//go:build cgo && webview && !darwin
+
+package goprovider
+
+import (
+	"testing"
+
+	"github.com/GopeedLab/gopeed/internal/webview/integrationtest"
+)
+
+func TestProviderContract(t *testing.T) {
+	integrationtest.RunProviderContract(t, New(), integrationtest.ContractOptions{
+		CookieDomainMode: integrationtest.CookieDomainModeRequired,
+	})
+}

…ernal/webview/goprovider/provider_cgo.go internal/webview/goprovider/provider.gointernal/webview/goprovider/provider_cgo.go renamed to internal/webview/goprovider/provider.go internal/webview/goprovider/provider_cgo.go renamed to internal/webview/goprovider/provider.go

@@ -1,4 +1,4 @@
-//go:build !cgo || !webview
+//go:build !cgo
 
 package goprovider