Skip to content

Windows stack overflow #116

Open
Open
@Buom01

Description

@Buom01

Hi,
I found why master branch binary doesn't run with a Stack Overflow error. There aren't recursions error, but two BIG tables.

Both in cl_console.ccp, there are

	char		text[CON_TEXTSIZE];
	vec4_t	text_color[CON_TEXTSIZE]; // New attribute of console_t

with #define CON_TEXTSIZE 163840

Particularly, in Con_CheckResize: You can comment everything separatly, but the binary will not work until you comment variables definitions:

	char		tbuf[CON_TEXTSIZE];
	vec4_t	tcbuf[CON_TEXTSIZE];

A simple solution is to reduce CON_TEXTSIZE to a reasonnable value. I suppose that it size were defined some time ago. The commit 38cbdc8 didn't touch CON_TEXTSIZE as seen in 38cbdc8#diff-fc5df3123cde35afd39dc251740cfdde6869b0349bc2124bcbfe9eb56b70df90

From there I have two suggestions:

  • Reducing CON_TEXTSIZE < 163840 / 4
  • Making console great again non verbose with useless information about pk3 loading and others, it's mostly a waste for most player, and there are already wrote into terminal (and maybe logs?)

Unfortunately, I will not create separate a pull request (as it's a time consuming pain to create a new branch not from my master and rebasing all my code not from it)

I will simply add a patch to #115

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions