fix: 🐛 Incorrect version when version type is build_timestamp

✅ Closes: #8

Author: GreatAuk

packages/core/src/index.ts

@@ -66,13 +66,22 @@ export function getTimestamp() {
  * @returns The version of the plugin.
  */
 export function getVersion(versionType: VersionType = 'git_commit_hash') {
+  const getVersionStrategies: Record<VersionType, () => string> = {
+    pkg_version: getHostProjectPkgVersion,
+    git_commit_hash: getGitCommitHash,
+    build_timestamp: getTimestamp,
+  }
   try {
-    if (versionType === 'git_commit_hash')
-      return getGitCommitHash()
-    if (versionType === 'pkg_version')
-      return getHostProjectPkgVersion()
+    const strategy = getVersionStrategies[versionType]
+    if (!strategy) {
+      console.warn(`
+      ======================================================
+      [plugin-web-update-notice] The version type '${versionType}' is not supported!, we will use the packaging timestamp instead.
+      ======================================================`)
+      return getTimestamp()
+    }
 
-    return getTimestamp()
+    return strategy()
   }
   catch (err) {
     console.warn(`

packages/vite-plugin/src/index.ts

@@ -51,6 +51,8 @@ function injectPluginHtml(html: string, version: string, options: Options) {
 
 export function webUpdateNotice(options: Options = {}): Plugin {
   // let viteConfig: ResolvedConfig;
+
+  const version = getVersion(options.versionType)
   return {
     name: 'vue-vite-web-update-notice',
     apply: 'build',
@@ -60,7 +62,6 @@ export function webUpdateNotice(options: Options = {}): Plugin {
     //   viteConfig = resolvedConfig;
     // },
     generateBundle(_, bundle = {}) {
-      const version = getVersion(options.versionType)
       if (!version)
         return
 
@@ -94,7 +95,6 @@ export function webUpdateNotice(options: Options = {}): Plugin {
     transformIndexHtml: {
       enforce: 'post',
       transform(html: string) {
-        const version = getVersion(options.versionType)
         if (version)
           return injectPluginHtml(html, version, options)
         return html

packages/webpack-plugin/src/index.ts

@@ -61,11 +61,11 @@ class WebUpdateNotificationPlugin {
   }
 
   apply(compiler: Compiler) {
+    const { hiddenDefaultNotification, versionType, indexHtmlFilePath } = this.options
+    const version = getVersion(versionType)
+
     compiler.hooks.emit.tap(pluginName, (compilation: Compilation) => {
       // const outputPath = compiler.outputPath
-      const { hiddenDefaultNotification, versionType } = this.options
-
-      const version = getVersion(versionType)
 
       const jsonFileContent = generateJSONFileContent(version)
       // @ts-expect-error
@@ -91,12 +91,10 @@ class WebUpdateNotificationPlugin {
     })
 
     compiler.hooks.afterEmit.tap(pluginName, () => {
-      const { indexHtmlFilePath } = this.options
       const htmlFilePath = resolve(compiler.outputPath, indexHtmlFilePath || './index.html')
       try {
         accessSync(htmlFilePath, constants.F_OK)
 
-        const version = getVersion(this.options.versionType)
         let html = readFileSync(htmlFilePath, 'utf8')
         html = injectPluginHtml(html, version, this.options)
         writeFileSync(htmlFilePath, html)