Defaults not merged on imported Inputs

[imix]

Description of the Error

When importing Inputs with the CSVImporter plugin, the Inputs are added to the list of inputs. Values specified in the "defaults" section are NOT merged with the values from the loaded csv. Furthermore a "dummy" empty Input is prepended to the loaded inputs.

Expected Behaviour

Defaults are merged in all inputs, regardless whether they are in the manifest or loaded from an external source. No additional line inserted.

The output section should look like this:

      outputs:
        - timestamp: '2023-12-12T00:00:15.000Z'
          random: default
          some/type: another
        - timestamp: '2023-12-12T00:00:17.000Z'
          random: default
          some/type: another

Actual Behaviour

At least for the CSVImporter plugin, the defaults are not merged. An addidional input is inserted before the inputs loaded from the CSV.

The outputs look like this:

      outputs:
        - random: default
          some/type: another
        - timestamp: '2023-12-12T00:00:15.000Z'
        - timestamp: '2023-12-12T00:00:17.000Z'

Steps to Reproduce

Run the manifest file below with the csv in the same folder.

Link to online environment

Manifest File That Generated the Error

name: csv-load-test
tags:
explainer: true
initialize:
  plugins:
    load-data:
      method: CSVImport
      path: 'builtin'
      config:
        filepath: ./load.csv
        output: "*"
tree:
  children:
    child:
      pipeline:
        observe:
          - load-data
        regroup:
        compute:
      defaults:
        random: 'default'
        some/type: 'another'
      inputs:

Links to Any Additional Code

load.csv:

timestamp
2023-12-12T00:00:15.000Z
2023-12-12T00:00:17.000Z

Runtime Info

OS: windows 11
node: v18.20.5
if: @grnsft/if@1.0.0

[narekhovhannisyan]

Hi @imix, thanks for reporting the issue. I'm checking this.

[imix]

Hi @narekhovhannisyan

Out of interest, I had a look at the code:

The "dummy" line seems to be created here:

if/src/if-run/lib/compute.ts

Line 56 in a202ce7

return defaults ? [defaults] : [];

Not sure why this is done.

The missing default seems to stem from the location mergeDefaults is called:
https://github.com/Green-Software-Foundation/if/blob/a202ce71dc4d970b98e090d7714677734112be5c/src/if-run/lib/compute.ts#L107C19-L107C32

Probably should be called after the observe plugins have been executed?

thanks for looking into it!

Stefan

[narekhovhannisyan]

Hi @imix (Stefan). Yes, it should be handled after observe plugins are called. I will provide fix soon.