Skip to content

Commit 4aeccbe

Browse files
authored
Merge pull request #1151 from muhAzri/master
Fix profile fields width by adding modifier support to BorderedTextField
2 parents 76f1978 + e9c4d2a commit 4aeccbe

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,4 +283,4 @@ configurations.all {
283283
}
284284
}
285285

286-
apply plugin: 'com.google.gms.google-services'
286+
apply plugin: 'com.google.gms.google-services'

app/src/main/java/org/greenstand/android/TreeTracker/view/BorderedTextField.kt

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import androidx.compose.foundation.BorderStroke
1919
import androidx.compose.foundation.border
2020
import androidx.compose.foundation.layout.Box
2121
import androidx.compose.foundation.layout.PaddingValues
22+
import androidx.compose.foundation.layout.fillMaxSize
2223
import androidx.compose.foundation.layout.padding
2324
import androidx.compose.foundation.shape.RoundedCornerShape
2425
import androidx.compose.foundation.text.KeyboardActions
@@ -40,30 +41,29 @@ import org.greenstand.android.TreeTracker.theme.CustomTheme
4041

4142
@Composable
4243
fun BorderedTextField(
44+
modifier: Modifier = Modifier,
4345
padding: PaddingValues = PaddingValues(0.dp),
4446
value: String,
45-
4647
onValueChange: (String) -> Unit,
4748
placeholder: @Composable (() -> Unit)? = null,
4849
keyboardOptions: KeyboardOptions = KeyboardOptions.Default,
4950
keyboardActions: KeyboardActions = KeyboardActions(),
5051
onFocusChanged: ((FocusState) -> Unit) = {},
5152
focusRequester: FocusRequester = FocusRequester.Default,
52-
autofocusEnabled: Boolean = false
53+
autofocusEnabled: Boolean = false,
5354
) {
5455
Box(
55-
modifier = Modifier
56+
modifier = modifier
5657
.padding(padding)
5758
.border(
5859
BorderStroke(0.5.dp, SolidColor(Color.White)),
5960
RoundedCornerShape(16.dp),
6061
)
61-
.padding(padding)
62-
6362
) {
6463
TextField(
6564
modifier = Modifier
6665
.padding(8.dp)
66+
.fillMaxSize()
6767
.focusRequester(focusRequester)
6868
.onFocusChanged(onFocusChanged),
6969
value = value,

app/src/main/java/org/greenstand/android/TreeTracker/view/ProfileField.kt

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ import androidx.compose.foundation.layout.Column
44
import androidx.compose.foundation.layout.PaddingValues
55
import androidx.compose.foundation.layout.fillMaxWidth
66
import androidx.compose.foundation.layout.padding
7-
import androidx.compose.material.MaterialTheme
8-
import androidx.compose.material.OutlinedTextField
97
import androidx.compose.material.Text
108
import androidx.compose.runtime.Composable
119
import androidx.compose.ui.Modifier
@@ -17,18 +15,21 @@ fun ProfileField(
1715
label: String,
1816
value: String,
1917
editable: Boolean,
20-
onValueChange: (String) -> Unit
18+
onValueChange: (String) -> Unit,
2119
) {
22-
Column(modifier = Modifier.fillMaxWidth().padding(vertical = 6.dp)) {
20+
Column(modifier = Modifier
21+
.fillMaxWidth()
22+
.padding(vertical = 6.dp)) {
2323
Text(label, style = CustomTheme.typography.medium, color = CustomTheme.textColors.lightText)
2424
if (editable) {
2525
BorderedTextField(
26-
padding = PaddingValues(top = 8.dp, ),
26+
padding = PaddingValues(top = 8.dp),
2727
value = value,
2828
onValueChange = onValueChange,
29+
modifier = Modifier.fillMaxWidth()
2930
)
3031
} else {
3132
Text(value, style = CustomTheme.typography.large)
3233
}
3334
}
34-
}
35+
}

0 commit comments

Comments
 (0)