fix: resolve broken wal tests

Author: JoeS51

src/common/meta/src/wal_provider.rs

@@ -74,7 +74,7 @@ impl WalProvider {
     }
 
     /// Allocates a batch of wal options where each wal options goes to a region.
-    /// If skip_wal is true, the wal options will be set to Noop regardless of the provider type.
+    /// skip_wal does not affect provider allocation.
     pub fn alloc_batch(&self, num_regions: usize, _skip_wal: bool) -> Result<Vec<WalOptions>> {
         match self {
             WalProvider::RaftEngine => Ok(vec![WalOptions::RaftEngine; num_regions]),

src/mito2/src/engine/alter_test.rs

@@ -2027,7 +2027,7 @@ async fn test_alter_region_enable_wal_on_legacy_noop_region_fails() {
         .await
         .unwrap_err();
 
-    let msg = err.to_string();
+    let msg = err.output_msg();
 
     assert!(
         msg.contains("Cannot enable WAL for legacy regions with noop wal_options"),

src/table/src/metadata.rs

@@ -1619,16 +1619,12 @@ mod tests {
             .build()
             .unwrap();
 
+        assert!(new_meta.options.skip_wal);
+
         assert_eq!(
-            Some("true"),
-            new_meta
-                .options
-                .extra_options
-                .get(SKIP_WAL_KEY)
-                .map(String::as_str)
+            Some(&"true".to_string()),
+            HashMap::from(&new_meta.options).get(SKIP_WAL_KEY)
         );
-
-        assert!(new_meta.options.skip_wal);
     }
 
     #[test]
@@ -1653,16 +1649,12 @@ mod tests {
             .build()
             .unwrap();
 
+        assert!(!new_meta.options.skip_wal);
+
         assert_eq!(
-            Some("false"),
-            new_meta
-                .options
-                .extra_options
-                .get(SKIP_WAL_KEY)
-                .map(String::as_str)
+            Some(&"false".to_string()),
+            HashMap::from(&new_meta.options).get(SKIP_WAL_KEY)
         );
-
-        assert!(!new_meta.options.skip_wal);
     }
 
     #[test]

src/table/src/requests.rs

@@ -40,7 +40,6 @@ use store_api::mito_engine_options::{
     TWCS_FALLBACK_TO_LOCAL, TWCS_MAX_OUTPUT_FILE_SIZE, TWCS_TIME_WINDOW, TWCS_TRIGGER_FILE_NUM,
     is_mito_engine_option_key,
 };
-use store_api::path_utils::WAL_DIR;
 use store_api::region_request::{SetRegionOption, UnsetRegionOption};
 
 use crate::error::{ParseTableOptionSnafu, Result};
@@ -193,7 +192,7 @@ impl TableOptions {
 
         options.extra_options = HashMap::from_iter(
             kvs.into_iter()
-                .filter(|(k, _)| k != WRITE_BUFFER_SIZE_KEY && k != TTL_KEY),
+                .filter(|(k, _)| k != WRITE_BUFFER_SIZE_KEY && k != TTL_KEY && k != SKIP_WAL_KEY),
         );
 
         Ok(options)