fix: sqids salting

lukas-frey · web-flow · commit f8c173104736 · 2024-08-27T15:07:14.000+02:00
diff --git a/src/Sqids.php b/src/Sqids.php
@@ -25,14 +25,12 @@ public function encode(array | int $numbers): string
 
     public function decode(string $id): array
     {
-        $output = parent::decode($id);
-
         if ($salt = $this->getSalt()) {
             srand($salt);
             $this->alphabet = str_shuffle($this->getAlphabet());
         }
 
-        return $output;
+        return parent::decode($id);
     }
 
     public static function make(array $parameters = []): static

Original file line number	Diff line number	Diff line change
`@@ -25,14 +25,12 @@ public function encode(array \| int $numbers): string`
`25`	`25`
`26`	`26`	`public function decode(string $id): array`
`27`	`27`	`{`
`28`		`- $output = parent::decode($id);`
`29`		`-`
`30`	`28`	`if ($salt = $this->getSalt()) {`
`31`	`29`	`srand($salt);`
`32`	`30`	`$this->alphabet = str_shuffle($this->getAlphabet());`
`33`	`31`	`}`
`34`	`32`
`35`		`- return $output;`
	`33`	`+ return parent::decode($id);`
`36`	`34`	`}`
`37`	`35`
`38`	`36`	`public static function make(array $parameters = []): static`