Skip to content

LatLngBounds extend error #32

@jimbok8

Description

@jimbok8

In LatLngsBounds the extend method is used to combine the present bounds with another bounds: using this method

 public void extend(LatLngBounds bounds) {
        if (bounds != null) {
            if (northEast == null) {
                northEast = new LatLng(bounds.getNorth(), bounds.getEast());
            }
            if (southWest == null) {
                southWest = new LatLng(bounds.getSouth(), bounds.getWest());
            }
            northEast.setLat(Math.max(northEast.getLat(), bounds.getSouthWest().getLat()));
            northEast.setLng(Math.max(northEast.getLng(), bounds.getSouthWest().getLng()));
            southWest.setLat(Math.min(southWest.getLat(), bounds.getNorthEast().getLat()));
            southWest.setLng(Math.min(southWest.getLng(), bounds.getNorthEast().getLng()));
        }
    }

I think the last 4 lines are wrong and should be:

            northEast.setLat(Math.max(northEast.getLat(), bounds.getNorthEast().getLat()));
            northEast.setLng(Math.max(northEast.getLng(), bounds.getNorthEast().getLng()));
            southWest.setLat(Math.min(southWest.getLat(), bounds.getSouthWest().getLat()));
            southWest.setLng(Math.min(southWest.getLng(), bounds.getSouthWest().getLng()));

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions