Wrong `total_space` information of Google Drive partition

[kimlimjustin]

Hello, firstly, thanks for your work on this awesome module.

I noticed that the size of the google drive partition seems to be incorrect. It shows up that I have about 11 GB of available space which is correct and 1 GB of total space which is incorrect. It should be 11GB/15GB, but it shows up 11GB/1GB.

Hope this could be fixed soon!

[GuillaumeGomez]

Unfortunately, there is no way for me to check such a specific setup... Could you maybe take a look?

The code you want to look at is here and here. One of the two calls might be doing something wrong or have the wrong unit...

Thanks in advance!

[kimlimjustin]

I'm so sorry but I'm new to Rust (just started 2 days ago), but I diagnosed the problem.

I tried to manually debug it and found out that It's probably because of these lines of code:

sysinfo/src/windows/tools.rs

Lines 78 to 87 in 1656418

	let result = DeviceIoControl(
	handle,
	IOCTL_DISK_GET_PARTITION_INFO_EX,
	std::ptr::null_mut(),
	0,
	&mut pdg as *mut PARTITION_INFORMATION_EX as *mut c_void,
	size_of::<PARTITION_INFORMATION_EX>() as DWORD,
	&mut junk,
	std::ptr::null_mut(),
	);

Unfortunately, I couldn't find any resources related to the DeviceIoControl, IOCTL_DISK_GET_PARTITIONI_INFO_EX functions (or maybe IDK how to do it on Rust). If you got the source code or any documentation related to these, I think I could check it.

Also, I guess that something went wrong with the function and it just return 1 GB as default, cuz 1073 741 824 is exactly the third power of 1024 which is perfectly 1GB.

Alternatively, another way to handle this is by firstly adding an if statement to check if the available_space is greater than total_space, if it does:

• First method
  • If the total_space is 1GB and the name is Google Drive and is unremovable, return 15GB (Google Drive's free capacity)
  • Otherwise, return an error.
• Second method
  • Calling the windows' wmic command.
    wmic logicaldisk get Caption,FreeSpace,Size,VolumeSerialNumber,Description /format:list returns the correct size. (Tho IDK if you want to add this into the library or just let the user to figure itself)

Regards

[GuillaumeGomez]

You need to look at microsoft's documentation directly:

• DeviceIoControl
• IOCTL_DISK_GET_PARTITION_INFO_EX

Then you can simply look at the equivalent in winapi documentation.

None of the methods you suggested would be a good idea:

• First method: It relies on way too many things that could go terribly wrong and would provide wrong information.
• Second method: Calling an external binary is extremely slow.

What I suggest to you: if you can provide a working C/C++ code which works, I can convert it to rust.

[kimlimjustin]

Erm, actually I'm not good at C/C++ too tho.

However, I found out that fsutil fsinfo command can return volume information as to what DeviceIoControl does and I tried it into the Google Drive partition and it returns A local NTFS volume is required for this operation while another partition returns the correct information, also I tried to input a partition that does not exist and it gives an additional error `Error: The system cannot find the file specified

Maybe that the function cannot read because the partition is a cloud-synced network(?) created by Google Drive. 👀

Also, to reproduce this install Google Drive Desktop and it will automatically create a partition there.

For my code, I think I'll add a checker manually and use the wmic if total_space is lesser than available_space for now and will update it if I figure out how to do it or you update the code. Really sorry can't help much.

Thanks.

[GuillaumeGomez]

To be clear: my windows is my work laptop, so I can't install anything on it, which is why I can't test it.

Well, until someone can take a look...