docs(changeset): Fix Node FS adapter and Translation replacments

Author: GuptaSiddhant

.changeset/empty-poems-obey.md

@@ -0,0 +1,6 @@
+---
+"@storybooker/adapter-fs": patch
+"@storybooker/core": patch
+---
+
+Fix Node FS adapter and Translation replacments

packages/adapter-fs/src/fs-storage.ts

@@ -1,8 +1,10 @@
+// oxlint-disable no-await-in-loop
+
 import * as fs from "node:fs";
 import * as fsp from "node:fs/promises";
 import * as path from "node:path";
-import { Readable } from "node:stream";
-import type { ReadableStream } from "node:stream/web";
+import { Readable, type Stream } from "node:stream";
+import type { ReadableStream as WebReadableStream } from "node:stream/web";
 import type { StorageService } from "@storybooker/core/types";
 
 export class LocalFileStorage implements StorageService {
@@ -89,19 +91,45 @@ export class LocalFileStorage implements StorageService {
   ) => {
     for (const file of files) {
       const filepath = this.#genPath(containerId, file.path);
-      const data =
-        // oxlint-disable-next-line no-nested-ternary
-        typeof file.content === "string"
-          ? file.content
-          : // oxlint-disable-next-line no-nested-ternary
-            file.content instanceof Blob
-            ? Readable.fromWeb(file.content.stream() as ReadableStream)
-            : Readable.fromWeb(file.content as ReadableStream);
-      // oxlint-disable-next-line no-await-in-loop
-      await fsp.writeFile(filepath, data, {
-        encoding: "utf8",
-        signal: options.abortSignal,
-      });
+      const dirpath = path.dirname(filepath);
+
+      await fsp.mkdir(dirpath, { recursive: true });
+      if (file.content instanceof ReadableStream) {
+        await writeWebStreamToFile(file.content, filepath);
+      } else {
+        const data: string | Stream =
+          // oxlint-disable-next-line no-nested-ternary
+          typeof file.content === "string"
+            ? file.content
+            : await file.content.text();
+
+        await fsp.writeFile(filepath, data, {
+          encoding: "utf8",
+          signal: options.abortSignal,
+        });
+      }
     }
   };
 }
+
+async function writeWebStreamToFile(
+  webReadableStream: ReadableStream,
+  outputPath: string,
+): Promise<null> {
+  // Convert WebReadableStream to Node.js Readable stream
+  const nodeReadableStream = Readable.fromWeb(
+    webReadableStream as WebReadableStream,
+  );
+
+  // Create a writable file stream
+  const fileWritableStream = fs.createWriteStream(outputPath);
+
+  // Pipe the Node.js readable stream to the writable file stream
+  nodeReadableStream.pipe(fileWritableStream);
+
+  // Return a promise that resolves when writing is finished
+  return new Promise((resolve, reject) => {
+    fileWritableStream.on("finish", () => resolve(null));
+    fileWritableStream.on("error", reject);
+  });
+}

packages/core/src/builds/model.ts

@@ -337,6 +337,8 @@ export class BuildsModel extends Model<BuildType> {
     dirpath: string,
     prefix: string,
   ): Promise<StoryBookerFile[]> => {
+    const { streaming } = getStore();
+
     const allEntriesInDir = await fsp.readdir(dirpath, {
       encoding: "utf8",
       recursive: true,
@@ -348,13 +350,15 @@ export class BuildsModel extends Model<BuildType> {
 
     return allFilesInDir.map((filepath): StoryBookerFile => {
       const relativePath = filepath.replace(`${dirpath}/`, "");
-      const stream = Readable.toWeb(
-        fs.createReadStream(filepath, { encoding: "binary" }),
-      );
-      // const content = await fsp.readFile(filepath, { encoding: "binary" });
+      const content =
+        streaming === false
+          ? fs.readFileSync(filepath, { encoding: "binary" })
+          : (Readable.toWeb(
+              fs.createReadStream(filepath, { encoding: "binary" }),
+            ) as ReadableStream);
 
       return {
-        content: stream as ReadableStream,
+        content,
         mimeType: getMimeType(filepath),
         path: path.posix.join(prefix, relativePath),
       };

packages/core/src/builds/ui/render.tsx

@@ -162,7 +162,7 @@ export function renderBuildDetailsPage({
             download={`storybook-${projectId}-${build.sha}.zip`}
             target="_blank"
           >
-            {commonT.Upload()} {commonT.StoryBook()}
+            {commonT.Download()} {commonT.StoryBook()}
           </a>
         ) : null}
       </DocumentSidebar>

packages/core/src/utils/i18n.ts

@@ -11,13 +11,15 @@ export function getT<
   replacements?: Record<string, string>,
 ): Translation[Category][Key] {
   const value = getStore().translation[category][key];
-  if (replacements && typeof value === "string") {
+
+  let translation: string = typeof value === "string" ? value : String(value);
+  if (replacements) {
     for (const rep of Object.entries(replacements)) {
-      value.replace(`{{${rep[0]}}}`, rep[1]);
+      translation = translation.replace(`{{${rep[0]}}}`, rep[1]);
     }
   }
 
-  return value;
+  return translation as typeof value;
 }
 
 export const commonT = {