fix clippy lints

Author: GyulyVGC

src/fields/fields.rs

@@ -26,12 +26,12 @@ impl Fields {
             let net_header = headers.net;
             let transport_header = headers.transport;
             Fields {
-                source: get_source(&net_header),
-                dest: get_dest(&net_header),
-                sport: get_sport(&transport_header),
-                dport: get_dport(&transport_header),
-                proto: get_proto(&net_header),
-                icmp_type: get_icmp_type(&transport_header),
+                source: get_source(net_header.as_ref()),
+                dest: get_dest(net_header.as_ref()),
+                sport: get_sport(transport_header.as_ref()),
+                dport: get_dport(transport_header.as_ref()),
+                proto: get_proto(net_header.as_ref()),
+                icmp_type: get_icmp_type(transport_header.as_ref()),
                 size: packet.len(),
             }
         } else {

src/fields/net_header.rs

@@ -2,7 +2,7 @@ use std::net::IpAddr;
 
 use etherparse::NetHeaders;
 
-pub(crate) fn get_source(net_header: &Option<NetHeaders>) -> Option<IpAddr> {
+pub(crate) fn get_source(net_header: Option<&NetHeaders>) -> Option<IpAddr> {
     if let Some(ip) = net_header {
         match ip {
             NetHeaders::Ipv4(h, _) => Some(IpAddr::from(h.source)),
@@ -14,7 +14,7 @@ pub(crate) fn get_source(net_header: &Option<NetHeaders>) -> Option<IpAddr> {
     }
 }
 
-pub(crate) fn get_dest(net_header: &Option<NetHeaders>) -> Option<IpAddr> {
+pub(crate) fn get_dest(net_header: Option<&NetHeaders>) -> Option<IpAddr> {
     if let Some(ip) = net_header {
         match ip {
             NetHeaders::Ipv4(h, _) => Some(IpAddr::from(h.destination)),
@@ -26,7 +26,7 @@ pub(crate) fn get_dest(net_header: &Option<NetHeaders>) -> Option<IpAddr> {
     }
 }
 
-pub(crate) fn get_proto(net_header: &Option<NetHeaders>) -> Option<u8> {
+pub(crate) fn get_proto(net_header: Option<&NetHeaders>) -> Option<u8> {
     if let Some(ip) = net_header {
         match ip {
             NetHeaders::Ipv4(h, _) => Some(h.protocol.0),

src/fields/transport_header.rs

@@ -1,6 +1,6 @@
 use etherparse::TransportHeader;
 
-pub(crate) fn get_sport(transport_header: &Option<TransportHeader>) -> Option<u16> {
+pub(crate) fn get_sport(transport_header: Option<&TransportHeader>) -> Option<u16> {
     if let Some(transport) = transport_header {
         match transport {
             TransportHeader::Tcp(h) => Some(h.source_port),
@@ -12,7 +12,7 @@ pub(crate) fn get_sport(transport_header: &Option<TransportHeader>) -> Option<u1
     }
 }
 
-pub(crate) fn get_dport(transport_header: &Option<TransportHeader>) -> Option<u16> {
+pub(crate) fn get_dport(transport_header: Option<&TransportHeader>) -> Option<u16> {
     if let Some(transport) = transport_header {
         match transport {
             TransportHeader::Tcp(h) => Some(h.destination_port),
@@ -24,7 +24,7 @@ pub(crate) fn get_dport(transport_header: &Option<TransportHeader>) -> Option<u1
     }
 }
 
-pub(crate) fn get_icmp_type(transport_header: &Option<TransportHeader>) -> Option<u8> {
+pub(crate) fn get_icmp_type(transport_header: Option<&TransportHeader>) -> Option<u8> {
     if let Some(transport) = transport_header {
         match transport {
             TransportHeader::Icmpv4(h) => Some(*h.to_bytes().first().unwrap()),

src/lib.rs

@@ -28,14 +28,11 @@
 //! [+] DIRECTION ACTION [OPTIONS]
 //! ```
 //!
-//! * Each rule can optionally be introduced by a `+` character; this will make the rule
-//! have higher priority (quick rule).
+//! * Each rule can optionally be introduced by a `+` character; this will make the rule have higher priority (quick rule).
 //!
-//! * `DIRECTION` can be either `IN` or `OUT` and represents the traffic directionality
-//! (see [`FirewallDirection`]).
+//! * `DIRECTION` can be either `IN` or `OUT` and represents the traffic directionality (see [`FirewallDirection`]).
 //!
-//! * `ACTION` can be either `ACCEPT`, `DENY`, or `REJECT` and represents the action
-//! associated with the rule (see [`FirewallAction`]).
+//! * `ACTION` can be either `ACCEPT`, `DENY`, or `REJECT` and represents the action associated with the rule (see [`FirewallAction`]).
 //!
 //! * For each rule, a list of **options** can be specified to match the desired traffic:
 //!   * `--dest`: destination IP addresses; the value is expressed in the form of a comma-separated

src/logs/log_entry.rs

@@ -54,8 +54,8 @@ impl Display for LogEntry {
             self.direction,
             self.action,
             format_proto(self.proto),
-            format_addr(&self.source),
-            format_addr(&self.dest),
+            format_addr(self.source.as_ref()),
+            format_addr(self.dest.as_ref()),
             format_port(self.sport),
             format_port(self.dport),
             format_icmp_type(self.icmp_type),
@@ -64,7 +64,7 @@ impl Display for LogEntry {
     }
 }
 
-fn format_addr(addr: &Option<LogIp>) -> String {
+fn format_addr(addr: Option<&LogIp>) -> String {
     if let Some(ip) = addr {
         ip.to_string()
     } else {