harden error handling

Author: GyulyVGC

src/cli/mod.rs

@@ -36,20 +36,24 @@ impl Args {
 
         #[cfg(all(windows, not(debug_assertions)))]
         if let Some(logs_file) = crate::utils::formatted_strings::get_logs_file_path() {
+            use crate::utils::error_logger::{ErrorLogger, Location};
             if args.logs {
-                std::process::Command::new("explorer")
+                if let Ok(mut explorer) = std::process::Command::new("explorer")
                     .arg(logs_file)
                     .spawn()
-                    .unwrap()
-                    .wait()
-                    .unwrap_or_default();
-                std::process::exit(0);
+                    .log_err(crate::location!())
+                {
+                    let _ = explorer.wait().log_err(crate::location!());
+                    std::process::exit(0);
+                }
+                std::process::exit(1);
             } else {
                 // truncate logs file
                 let _ = std::fs::OpenOptions::new()
                     .write(true)
                     .truncate(true)
-                    .open(logs_file);
+                    .open(logs_file)
+                    .log_err(crate::location!());
             }
         }
 

src/networking/types/info_traffic.rs

@@ -98,7 +98,10 @@ impl InfoTraffic {
             DataRepr::Packets => u128::from(self.dropped_packets),
             DataRepr::Bytes | DataRepr::Bits => {
                 // assume that the dropped packets have the same size as the average packet
-                u128::from(self.dropped_packets) * all / all_packets
+                u128::from(self.dropped_packets)
+                    .saturating_mul(all)
+                    .checked_div(all_packets)
+                    .unwrap_or_default()
             }
         };
 

src/notifications/types/notifications.rs

@@ -103,8 +103,10 @@ impl DataNotification {
             let without_multiple: String = chars[0..chars.len() - 1].iter().collect();
             if without_multiple.parse::<u64>().is_ok()
                 && TryInto::<u64>::try_into(
-                    without_multiple.parse::<u128>().unwrap_or_default()
-                        * u128::from(byte_multiple_inserted.multiplier()),
+                    without_multiple
+                        .parse::<u128>()
+                        .unwrap_or_default()
+                        .saturating_mul(u128::from(byte_multiple_inserted.multiplier())),
                 )
                 .is_ok()
             {

src/report/types/report_col.rs

@@ -47,7 +47,11 @@ impl ReportCol {
             ReportCol::Service => service_translation(language).to_string(),
             ReportCol::Data => {
                 let mut str = data_repr.get_label(language).to_string();
-                str.remove(0).to_uppercase().to_string() + &str
+                if str.is_empty() {
+                    str
+                } else {
+                    str.remove(0).to_uppercase().to_string() + &str
+                }
             }
         }
     }