unify packets & bytes threshold notifications

Author: GyulyVGC

resources/fonts/subset/icons.ttf

@@ -1,8 +1,9 @@
 use crate::Language;
 use crate::translations::translations::{bytes_translation, packets_translation};
+use serde::{Deserialize, Serialize};
 
 /// Enum representing the possible kind of chart displayed.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
 pub enum ChartType {
     Packets,
     Bytes,

src/chart/types/chart_type.rs

@@ -98,8 +98,7 @@ mod tests {
                 ),
                 notifications: Notifications {
                     volume: 100,
-                    packets_notification: Default::default(),
-                    bytes_notification: Default::default(),
+                    data_notification: Default::default(),
                     favorite_notification: Default::default(),
                 },
                 style: StyleType::Custom(ExtraStyles::DraculaDark),

src/cli/mod.rs

@@ -62,8 +62,7 @@ pub fn notifications_page(sniffer: &Sniffer) -> Container<Message, StyleType> {
 
     tab_and_body = tab_and_body.push(tabs);
 
-    if notifications.packets_notification.threshold.is_none()
-        && notifications.bytes_notification.threshold.is_none()
+    if notifications.data_notification.threshold.is_none()
         && !notifications.favorite_notification.notify_on_favorite
         && sniffer.logged_notifications.0.is_empty()
     {
@@ -157,10 +156,10 @@ fn data_notification_log<'a>(
     } else {
         logged_notification.threshold.to_string()
     };
-    let icon = if chart_type == ChartType::Bytes {
-        Icon::BytesThreshold
-    } else {
+    let icon = if chart_type == ChartType::Packets {
         Icon::PacketsThreshold
+    } else {
+        Icon::BytesThreshold
     }
     .to_text()
     .size(80)
@@ -244,7 +243,6 @@ fn favorite_notification_log<'a>(
             Icon::Star
                 .to_text()
                 .size(80)
-                .class(TextType::Starred)
                 .line_height(LineHeight::Relative(1.0)),
         )
         .push(