Skip to content

Commit 993b0e6

Browse files
committed
general settings: include link to GitHub Issues
1 parent 3ad849f commit 993b0e6

5 files changed

Lines changed: 47 additions & 42 deletions

File tree

src/gui/pages/settings_general_page.rs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use iced::widget::tooltip::Position;
33
use iced::widget::{
44
Column, Container, PickList, Row, Rule, Slider, Space, Text, Tooltip, button, vertical_space,
55
};
6-
use iced::{Alignment, Font, Length};
6+
use iced::{Alignment, Font, Length, Padding};
77

88
use crate::gui::components::button::{button_open_file, row_open_link_tooltip};
99
use crate::gui::components::tab::get_settings_tabs;
@@ -18,9 +18,9 @@ use crate::mmdb::types::mmdb_reader::{MmdbReader, MmdbReaders};
1818
use crate::translations::translations::language_translation;
1919
use crate::translations::translations_2::country_translation;
2020
use crate::translations::translations_3::{
21-
learn_more_translation, mmdb_files_translation, params_not_editable_translation,
22-
zoom_translation,
21+
mmdb_files_translation, params_not_editable_translation, zoom_translation,
2322
};
23+
use crate::translations::translations_4::share_feedback_translation;
2424
use crate::utils::formatted_strings::get_path_termination_string;
2525
use crate::utils::types::file_info::FileInfo;
2626
use crate::utils::types::icon::Icon;
@@ -206,7 +206,7 @@ fn need_help<'a>(language: Language, font: Font) -> Container<'a, Message, Style
206206
let content = Column::new()
207207
.align_x(Alignment::Center)
208208
.push(
209-
Text::new(learn_more_translation(language))
209+
Text::new(share_feedback_translation(language))
210210
.class(TextType::Subtitle)
211211
.size(FONT_SIZE_SUBTITLE)
212212
.font(font),
@@ -215,18 +215,18 @@ fn need_help<'a>(language: Language, font: Font) -> Container<'a, Message, Style
215215
.push(
216216
Tooltip::new(
217217
button(
218-
Icon::Book
218+
Icon::Feedback
219219
.to_text()
220220
.align_y(Alignment::Center)
221221
.align_x(Alignment::Center)
222-
.size(22)
222+
.size(20)
223223
.line_height(LineHeight::Relative(1.0)),
224224
)
225-
.on_press(Message::OpenWebPage(WebPage::Wiki))
226-
.padding(2)
225+
.on_press(Message::OpenWebPage(WebPage::Issues))
226+
.padding(Padding::new(2.0).top(5))
227227
.height(40)
228228
.width(60),
229-
row_open_link_tooltip("Wiki", font),
229+
row_open_link_tooltip("GitHub Issues", font),
230230
Position::Right,
231231
)
232232
.gap(5)

src/translations/translations_3.rs

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -550,28 +550,28 @@ pub fn thumbnail_mode_translation(language: Language) -> &'static str {
550550
}
551551
}
552552

553-
pub fn learn_more_translation(language: Language) -> &'static str {
554-
match language {
555-
Language::EN => "Do you want to learn more?",
556-
// Language::FA => "آیا می خواهید بیشتر یاد بگیرید؟",
557-
Language::IT => "Vuoi saperne di più?",
558-
Language::FR => "Voulez-vous en savoir davantage?",
559-
Language::DE => "Mehr erfahren",
560-
Language::PL => "Chcesz dowiedzieć się więcej?",
561-
Language::RU => "Хотите узнать больше?",
562-
Language::RO => "Vrei să înveți mai multe?",
563-
Language::JA => "もっと知りたいですか?",
564-
Language::UZ => "Ko'proq bilishni hohlaysizmi?",
565-
Language::SV => "Vill du veta mer?",
566-
Language::VI => "Bạn có muốn tìm hiểu thêm?",
567-
Language::ZH => "想知道更多吗?",
568-
Language::ZH_TW => "想了解更多嗎?",
569-
Language::KO => "더 자세히 알고 싶으십니까?",
570-
Language::TR => "Daha fazlasını öğrenmek ister misin?",
571-
Language::PT => "Quer aprender mais?",
572-
Language::UK => "Бажаєте дізнатись більше?",
573-
Language::ID => "Apakah kamu mau belajar lebih lanjut?",
574-
Language::ES => "¿Quieres aprender más?",
575-
_ => "Do you want to learn more?",
576-
}
577-
}
553+
// pub fn learn_more_translation(language: Language) -> &'static str {
554+
// match language {
555+
// Language::EN => "Do you want to learn more?",
556+
// // Language::FA => "آیا می خواهید بیشتر یاد بگیرید؟",
557+
// Language::IT => "Vuoi saperne di più?",
558+
// Language::FR => "Voulez-vous en savoir davantage?",
559+
// Language::DE => "Mehr erfahren",
560+
// Language::PL => "Chcesz dowiedzieć się więcej?",
561+
// Language::RU => "Хотите узнать больше?",
562+
// Language::RO => "Vrei să înveți mai multe?",
563+
// Language::JA => "もっと知りたいですか?",
564+
// Language::UZ => "Ko'proq bilishni hohlaysizmi?",
565+
// Language::SV => "Vill du veta mer?",
566+
// Language::VI => "Bạn có muốn tìm hiểu thêm?",
567+
// Language::ZH => "想知道更多吗?",
568+
// Language::ZH_TW => "想了解更多嗎?",
569+
// Language::KO => "더 자세히 알고 싶으십니까?",
570+
// Language::TR => "Daha fazlasını öğrenmek ister misin?",
571+
// Language::PT => "Quer aprender mais?",
572+
// Language::UK => "Бажаєте дізнатись більше?",
573+
// Language::ID => "Apakah kamu mau belajar lebih lanjut?",
574+
// Language::ES => "¿Quieres aprender más?",
575+
// _ => "Do you want to learn more?",
576+
// }
577+
// }

src/translations/translations_4.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ pub fn reserved_address_translation(language: Language, info: &str) -> String {
1616
}
1717
}
1818

19-
// pub fn share_feedback_translation(language: Language) -> &'static str {
20-
// match language {
21-
// Language::EN => "Share your feedback",
22-
// Language::IT => "Condividi il tuo feedback",
23-
// Language::ZH_TW => "分享您的意見回饋",
24-
// _ => "Share your feedback",
25-
// }
26-
// }
19+
pub fn share_feedback_translation(language: Language) -> &'static str {
20+
match language {
21+
Language::EN => "Share your feedback",
22+
Language::IT => "Condividi il tuo feedback",
23+
Language::ZH_TW => "分享您的意見回饋",
24+
_ => "Share your feedback",
25+
}
26+
}
2727

2828
// refers to bytes or packets excluded because of the filters
2929
pub fn excluded_translation(language: Language) -> &'static str {

src/utils/types/icon.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ pub enum Icon {
1919
Generals,
2020
Error,
2121
// Expand,
22+
Feedback,
2223
File,
2324
Forbidden,
2425
Funnel,
@@ -67,6 +68,7 @@ impl Icon {
6768
Icon::Clock => '9',
6869
Icon::Generals => 'Q',
6970
Icon::Error => 'U',
71+
Icon::Feedback => '=',
7072
Icon::File => '8',
7173
Icon::Forbidden => 'x',
7274
Icon::Funnel => 'V',

src/utils/types/web_page.rs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ pub enum WebPage {
1313
WebsiteSponsor,
1414
/// Sniffnet Roadmap
1515
Roadmap,
16+
/// Sniffnet issues on GitHub
17+
Issues,
1618
/// Sniffnet issue #60 on GitHub
1719
IssueLanguages,
1820
/// Sniffnet Wiki
@@ -30,6 +32,7 @@ impl WebPage {
3032
WebPage::WebsiteDownload => "https://www.sniffnet.net/download",
3133
WebPage::WebsiteNews => "https://www.sniffnet.net/news",
3234
WebPage::Roadmap => "https://whimsical.com/sniffnet-roadmap-Damodrdfx22V9jGnpHSCGo",
35+
WebPage::Issues => "https://github.com/GyulyVGC/sniffnet/issues",
3336
WebPage::IssueLanguages => "https://github.com/GyulyVGC/sniffnet/issues/60",
3437
WebPage::Wiki => "https://github.com/GyulyVGC/sniffnet/wiki",
3538
WebPage::MyGitHub => "https://github.com/GyulyVGC",

0 commit comments

Comments
 (0)