Skip to content

Commit 1ddc7a6

Browse files
mwvossjdkent
authored andcommitted
ENH: Update getroicorrs for crest (#97)
* update paths and comments * try to make run_getroicorrs recognized as octave with shebang * fold in getroicorrs function and edits to match up variables * update paths to find wrappers in docker container * update comments * add comment on how to output seedmaps * changes to getroicorrs but note we won't call this anymore, it's folded into run_getroicorrs * add run_getroicorrs test to circleci * update run_getroicorrs files to take input of subject list and roilist * remove hardcoding * modify circleci to test roi-roi separately * move the mv command * change subnum to sub-num for bids * remove dashes from filename * try to fix paths for nuisance rois and add clobber since rois are running through roi loop * add test for nuisance roi to fix access error in roi loop * make fname more robust to text in subject label
1 parent 9484ed5 commit 1ddc7a6

File tree

7 files changed

+216
-192
lines changed

7 files changed

+216
-192
lines changed

.circleci/config.yml

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,10 +118,10 @@ jobs:
118118
--t1_mask=/data/derivatives/bet/sub-01/anat/sub-01_desc-brainmask_T1w.nii.gz \
119119
--roiList=/data/derivatives/data/roi_list.txt \
120120
--compcor
121-
mv /tmp/data/ds005/derivatives/rsOut /tmp/data/ds005/derivatives/rsOutCompcor
122121
- run:
123122
name: Check compcor outputs
124123
command: |
124+
mv /tmp/data/ds005/derivatives/rsOut /tmp/data/ds005/derivatives/rsOutCompcor
125125
mkdir -p /tmp/ds005/test
126126
find /tmp/data/ds005/derivatives/rsOutCompcor -type f | sed s+/tmp/data/ds005/derivatives/rsOutCompcor++ | sort > /tmp/ds005/test/outputs-compcor.out
127127
diff /tmp/src/RestingState/.circleci/ds005_compcor.txt /tmp/ds005/test/outputs-compcor.out
@@ -131,6 +131,7 @@ jobs:
131131
- run:
132132
name: Test --compcor_global
133133
command: |
134+
# run the original script
134135
docker run -ti --rm=false \
135136
-v /tmp/data/ds005:/data \
136137
hbclab/restingstate:latest \
@@ -139,10 +140,29 @@ jobs:
139140
--t1_mask=/data/derivatives/bet/sub-01/anat/sub-01_desc-brainmask_T1w.nii.gz \
140141
--roiList=/data/derivatives/data/roi_list.txt \
141142
--compcor_global
142-
mv /tmp/data/ds005/derivatives/rsOut /tmp/data/ds005/derivatives/rsOutCompcorGlobal
143+
- run:
144+
name: Test roi-roi correlations
145+
command: |
146+
# inputs for run_getroicorrs
147+
mkdir -p /tmp/ds005/test
148+
echo "sub-01" > /tmp/ds005/test/subList.txt
149+
echo -e "UIUC_VIS_lvis\nUIUC_VIS_rvis" > /tmp/ds005/test/roiList.txt
150+
151+
# get individual roi-roi correlations
152+
docker run -it \
153+
-v /tmp/data/ds005:/data \
154+
-v /tmp:/tmp \
155+
--entrypoint /opt/RestingState/run_getroicorrs_shell_wrapper.sh \
156+
hbclab/restingstate:latest \
157+
/data/derivatives/rsOut/ \
158+
/tmp/ds005/test/subList.txt \
159+
/tmp/ds005/test/roiList.txt
143160
- run:
144161
name: Check compcor_global outputs
145162
command: |
163+
# move rsOut to it's own directory
164+
mv /tmp/data/ds005/derivatives/rsOut /tmp/data/ds005/derivatives/rsOutCompcorGlobal
165+
146166
mkdir -p /tmp/ds005/test
147167
find /tmp/data/ds005/derivatives/rsOutCompcorGlobal -type f | sed s+/tmp/data/ds005/derivatives/rsOutCompcorGlobal++ | sort > /tmp/ds005/test/outputs-compcor_global.out
148168
diff /tmp/src/RestingState/.circleci/ds005_compcor_global.txt /tmp/ds005/test/outputs-compcor_global.out

.circleci/ds005_compcor_global.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
/anat/sub-01/tissueSeg/T1_seg_1.nii.gz
2121
/anat/sub-01/tissueSeg/T1_seg_2.nii.gz
2222
/anat/sub-01/tissueSeg/T1_seg.nii.gz
23+
/roicorrs/roi-roi_corr.csv
24+
/roicorrs/sub-01.mat
25+
/roicorrs/subject_roi-pair_corr.csv
2326
/sub-01/3dTqual.png
2427
/sub-01/analysisResults.html
2528
/sub-01/AntNoise_Mean.par

getroicorrs.m

Lines changed: 0 additions & 134 deletions
This file was deleted.

processRestingState_bids_wrapper.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,7 @@ clobber "${epiDataFiltReg}" &&\
542542
clobber "${rsOut}"/motionScrub/"$(basename "${epiDataFiltReg/.nii/_ms.nii}")" &&\
543543
"${scriptdir}"/motionScrub.sh --epi="${epiDataFiltReg}"
544544

545+
# add --seedmaps option if you want to get 3D seed-to-voxel fishers correlation map
545546
"${scriptdir}"/seedVoxelCorrelation.sh \
546547
--epi="${epiDataFiltReg}" \
547548
--motionscrub \

removeNuisanceRegressor.sh

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -365,10 +365,19 @@ do
365365
fslmeants -i "$epiData" -o "$outDir"/rois/mean_"${roiName}"_ts.txt -m "$outDir"/rois/"${roiName}"_native.nii.gz --eig --order=5
366366
elif [[ "${compcor_globalFlag}" -eq 1 ]]; then
367367
# mean for global
368-
fslmeants -i "$epiData" -o "$outDir"/rois/mean_global_ts.txt -m "$outDir"/rois/global_native.nii.gz
368+
clobber "$outDir"/rois/mean_global_ts.txt &&\
369+
if [ -f "$outDir"/rois/global_native.nii.gz ]; then
370+
fslmeants -i "$epiData" -o "$outDir"/rois/mean_global_ts.txt -m "$outDir"/rois/global_native.nii.gz
371+
fi
369372
# eigenvariates for WM and CSF
370-
fslmeants -i "$epiData" -o "$outDir"/rois/mean_CSF_pve_to_RS_thresh_ts.txt -m "$outDir"/rois/CSF_pve_to_RS_thresh_native.nii.gz --eig --order=5
371-
fslmeants -i "$epiData" -o "$outDir"/rois/mean_WM_pve_to_RS_thresh_ero_ts.txt -m "$outDir"/rois/WM_pve_to_RS_thresh_ero_native.nii.gz --eig --order=5
373+
clobber "$outDir"/rois/mean_CSF_pve_to_RS_thresh_ts.txt &&\
374+
if [ -f "$outDir"/rois/CSF_pve_to_RS_thresh_native.nii.gz ]; then
375+
fslmeants -i "$epiData" -o "$outDir"/rois/mean_CSF_pve_to_RS_thresh_ts.txt -m "$outDir"/rois/CSF_pve_to_RS_thresh_native.nii.gz --eig --order=5
376+
fi
377+
clobber "$outDir"/rois/mean_WM_pve_to_RS_thresh_ero_ts.txt &&\
378+
if [ -f "$outDir"/rois/WM_pve_to_RS_thresh_ero_native.nii.gz ]; then
379+
fslmeants -i "$epiData" -o "$outDir"/rois/mean_WM_pve_to_RS_thresh_ero_ts.txt -m "$outDir"/rois/WM_pve_to_RS_thresh_ero_native.nii.gz --eig --order=5
380+
fi
372381
else
373382
clobber "$outDir"/rois/mean_"${roiName}"_ts.txt &&\
374383
fslmeants -i "$epiData" -o "$outDir"/rois/mean_"${roiName}"_ts.txt -m "$outDir"/rois/"${roiName}"_native.nii.gz

0 commit comments

Comments
 (0)